-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel from XY #514
Channel from XY #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but looks great! Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #514 +/- ##
===========================================
+ Coverage 89.77% 89.80% +0.03%
===========================================
Files 92 92
Lines 6054 6072 +18
===========================================
+ Hits 5435 5453 +18
Misses 619 619
Continue to review full report in Codecov by Sentry.
|
Context:
We would like to have the ability to initialize a Channel from its X,Y matrices (and potentially a d vector).
Description of the Change:
Added the method
.from_XY
which allows this computation.Benefits:
Provides a simpler way for a user to initialize their desired channel.
Possible Drawbacks:
None.
Related GitHub Issues:
None.