Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel from XY #514

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Channel from XY #514

merged 9 commits into from
Oct 30, 2024

Conversation

arsalan-motamedi
Copy link
Collaborator

Context:
We would like to have the ability to initialize a Channel from its X,Y matrices (and potentially a d vector).

Description of the Change:
Added the method .from_XY which allows this computation.

Benefits:
Provides a simpler way for a user to initialize their desired channel.

Possible Drawbacks:
None.

Related GitHub Issues:
None.

@arsalan-motamedi arsalan-motamedi added the no changelog Pull request does not require a CHANGELOG entry label Oct 28, 2024
Copy link
Collaborator

@apchytr apchytr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but looks great! Thanks!

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (e5c02ce) to head (517d6f5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #514      +/-   ##
===========================================
+ Coverage    89.77%   89.80%   +0.03%     
===========================================
  Files           92       92              
  Lines         6054     6072      +18     
===========================================
+ Hits          5435     5453      +18     
  Misses         619      619              
Files with missing lines Coverage Δ
mrmustard/lab_dev/transformations/base.py 99.42% <100.00%> (+0.01%) ⬆️
mrmustard/physics/triples.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c02ce...517d6f5. Read the comment docs.

@arsalan-motamedi arsalan-motamedi merged commit 3a1d8bb into develop Oct 30, 2024
8 checks passed
@arsalan-motamedi arsalan-motamedi deleted the from_xy branch October 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants