-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove julia
code and dependencies
#541
Conversation
**Context:** Julia code was introduced previously to try and work around algorithmic instabilities in the computation of Fock coefficients from Gaussian Bargmann functions. This introduced a hard dependency on `julia`, which made installation tricker. In the end, it was found that the more stable approach was achieved by changing the algorithm to average over the possible lattice sites. **Description of the Change:** This change removes the `julia` code and the dependencies of that code. The PRECISION_BITS_HERMITE_POLY setting is removed, as that was the switch to turn on the `julia` implementation. The `julia` code has been pushed into the branch <https://github.com/XanaduAI/GaussianBargmannFock> which stores implementations of this function. **Benefits:** There is no hard dependency on `juliacall` and the `julia` language. This should ease installation, particularly on Windows platforms. **Possible Drawbacks:** The ability switch to using the `julia` implementation is gone without a setting to bring it back quickly. Signed-off-by: Anthony <[email protected]>
happy to see the hard dependency go away, though I have some questions:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #541 +/- ##
===========================================
- Coverage 90.08% 90.05% -0.04%
===========================================
Files 102 102
Lines 6243 6222 -21
===========================================
- Hits 5624 5603 -21
Misses 619 619
Continue to review full report in Codecov by Sentry.
|
I get this error with
|
@aplund what version of poetry do you have installed? Is the environment a fresh one? |
It's not a fresh env, but I can rebuild it and try again:
|
Yeah can you try with poetry 1.8.5 and a fresh env? If that doesnt work Im not sure what's happening since I cant reproduce the error locally |
Looks like poetry is super-picky for minor version numbers. I used 1.8.5 and all good. |
re: trying it. I did, and I hit this issue: JuliaLang/julia#52205 I tried the simple solutions, and they didn't work. Ultimately, downloading Julia manually and following this comment worked, but this is unfortunately involved for Windows users. |
Opening on behalf of @aplund
Context: Julia code was introduced previously to try and work around algorithmic instabilities in the computation of Fock coefficients from Gaussian Bargmann functions. This introduced a hard dependency on
julia
, which made installation tricker. In the end, it was found that the more stable approach was achieved by changing the algorithm to average over the possible lattice sites.Description of the Change: This change removes the
julia
code and the dependencies of that code. The PRECISION_BITS_HERMITE_POLY setting is removed, as that was the switch to turn on thejulia
implementation. Thejulia
code has been pushed into the branchhttps://github.com/XanaduAI/GaussianBargmannFock which stores implementations of this function.
Benefits: There is no hard dependency on
juliacall
and thejulia
language. This should ease installation, particularly on Windows platforms.Possible Drawbacks: The ability switch to using the
julia
implementation is gone without a setting to bring it back quickly.