Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve robustness of GDIT Action #56

Merged
merged 22 commits into from
Oct 30, 2023
Merged

Improve robustness of GDIT Action #56

merged 22 commits into from
Oct 30, 2023

Conversation

Mandrenkov
Copy link
Contributor

@Mandrenkov Mandrenkov commented Oct 27, 2023 •
edited
Loading

Changes

  • Partitioned the Generate Docker Images Tags (GDIT) action into several more steps.
  • Replaced the sketchy regular expression for parsing PR numbers with a call to the GitHub API.

@Mandrenkov Mandrenkov marked this pull request as ready for review October 27, 2023 21:06
michaelvu97
michaelvu97 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@michaelvu97 michaelvu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mandrenkov Mandrenkov merged commit 25c9c4a into main Oct 30, 2023
@Mandrenkov Mandrenkov deleted the sc-48714-robust-docker-image-tag-generation branch October 30, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelvu97 michaelvu97 michaelvu97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mandrenkov @michaelvu97