Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SYMPY_USE_CACHE environment variable to "no" #684

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

thisac
Copy link
Contributor

@thisac thisac commented Feb 24, 2022

Context:
Quick fix for an issue with SymPy caching expressions and wrongly using a cached register reference instead of the new one. See issue #683 for details.

Description of the Change:
Sets the SYMPY_USE_CACHE environment variable to "no" in CI, so that no caching is done when running tests.

Benefits:
Certain cases when SymPy parameters are cached and incorrectly retrieved will (hopefully) no longer happen in the CI tests.

Possible Drawbacks:
This is just a quick fix for the CI tests. The issue is still present in the code-base.

Related GitHub Issues:
#683

@thisac thisac self-assigned this Feb 24, 2022
@thisac thisac requested a review from josh146 February 24, 2022 19:22
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #684 (930831a) into master (de3bdf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          75       75           
  Lines        9163     9163           
=======================================
  Hits         9011     9011           
  Misses        152      152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3bdf4...930831a. Read the comment docs.

@thisac thisac merged commit c18b9ed into master Feb 25, 2022
@thisac thisac deleted the no-sympy-cache branch February 25, 2022 17:03
@thisac thisac mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants