This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add Hama support #60
Merged
Add Hama support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A tweak to the existing regex at line 89 wouldn't suffice? Line 89 in 415dc93 + re := regexp.MustCompile("tvdb(?:://|[2-5]?-)(\\d*)/(\\d*)/(\\d*)") |
|
Thanks for this! |
BrutuZ
added a commit
to BrutuZ/goplaxt
that referenced
this pull request
Sep 18, 2021
Improve on XanderStrike#60 by shaving a check and supporting HAMA's* [additional TVDB mapping modes](https://github.com/ZeroQI/Absolute-Series-Scanner#forcing-the-movieseries-id) *= ASS's actually, but HAMA will inherit it [x] Tested and working
XanderStrike
pushed a commit
that referenced
this pull request
Sep 21, 2021
Improve on #60 by shaving a check and supporting HAMA's* [additional TVDB mapping modes](https://github.com/ZeroQI/Absolute-Series-Scanner#forcing-the-movieseries-id) *= ASS's actually, but HAMA will inherit it [x] Tested and working
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
In the future, Hama will probably support TMDB series IDs because of ZeroQI/Hama.bundle#457, then the code needs to be changed again.
But until then, my proposed code is probably enough.