Skip to content

Commit

Permalink
chore: bump versions of dependencies, small refactor on errors -> use…
Browse files Browse the repository at this point in the history
… macros
  • Loading branch information
DashieTM committed May 6, 2024
1 parent 822a6a7 commit 8466008
Show file tree
Hide file tree
Showing 14 changed files with 1,241 additions and 57 deletions.
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
[package]
name = "reset"
version = "1.1.1"
version = "1.2.0"
edition = "2021"
description = "A wip universal Linux settings application."
repository = "https://github.com/Xetibo/ReSet"
license = "GPL-3.0-or-later"

[dependencies]
#reset_daemon = { git = "https://github.com/Xetibo/ReSet-Daemon", branch = "dashie" }
reset_daemon = "1.2.1"
#re_set-lib = { git = "https://github.com/Xetibo/ReSet-Lib" , branch = "audioobject"}
re_set-lib = "3.3.0"
reset_daemon = "1.3.1"
re_set-lib = "3.4.1"
adw = { version = "0.6.0", package = "libadwaita", features = ["v1_4"] }
dbus = "0.9.7"
gtk = { version = "0.8.1", package = "gtk4", features = ["v4_12"] }
Expand Down
26 changes: 19 additions & 7 deletions src/components/audio/audio_box_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ use gtk::{
use re_set_lib::{
audio::audio_structures::{Card, TAudioObject, TAudioStreamObject},
signals::{TAudioEventRemoved, TAudioObjectEvent, TAudioStreamEvent},
ERROR,
};

#[cfg(debug_assertions)]
use re_set_lib::{utils::macros::ErrorLevel, write_log_to_file};

use crate::components::{
base::{card_entry::CardEntry, error_impl::ReSetErrorImpl, list_entry::ListEntry},
utils::{create_dropdown_label_factory, set_combo_row_ellipsis, BASE, DBUS_PATH},
Expand Down Expand Up @@ -365,8 +369,7 @@ pub fn start_audio_box_listener<
>(object_added_box.clone(), ir, dummy_name)
});
if res.is_err() {
// TODO: handle this with the log/error macro
println!("fail on source add event");
ERROR!("fail on source add event", ErrorLevel::PartialBreakage);
return conn;
}

Expand All @@ -384,7 +387,7 @@ pub fn start_audio_box_listener<
>(object_changed_box.clone(), ir, get_default_name_function)
});
if res.is_err() {
println!("fail on source change event");
ERROR!("fail on source change event", ErrorLevel::PartialBreakage);
return conn;
}

Expand All @@ -402,7 +405,7 @@ pub fn start_audio_box_listener<
>(object_removed_box.clone(), ir, dummy_name)
});
if res.is_err() {
println!("fail on source remove event");
ERROR!("fail on source remove event", ErrorLevel::PartialBreakage);
return conn;
}

Expand All @@ -420,7 +423,10 @@ pub fn start_audio_box_listener<
>(stream_added_box.clone(), ir)
});
if res.is_err() {
println!("fail on output stream add event");
ERROR!(
"fail on output stream add event",
ErrorLevel::PartialBreakage
);
return conn;
}

Expand All @@ -438,7 +444,10 @@ pub fn start_audio_box_listener<
>(stream_changed_box.clone(), ir)
});
if res.is_err() {
println!("fail on output stream change event");
ERROR!(
"fail on output stream change event",
ErrorLevel::PartialBreakage
);
return conn;
}

Expand All @@ -456,7 +465,10 @@ pub fn start_audio_box_listener<
>(stream_removed_box.clone(), ir)
});
if res.is_err() {
println!("fail on output stream remove event");
ERROR!(
"fail on output stream remove event",
ErrorLevel::PartialBreakage
);
return conn;
}

Expand Down
1 change: 0 additions & 1 deletion src/components/base/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ impl ReSetError {
.imp()
.reset_error_button
.connect_clicked(clone!(@strong error => move |_| {
println!("pingpangpung");
error.popdown();
}));
error
Expand Down
25 changes: 20 additions & 5 deletions src/components/bluetooth/bluetooth_box.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,14 @@ use glib::{clone, ControlFlow};
use gtk::glib::Variant;
use gtk::prelude::{ActionableExt, ButtonExt, ListBoxRowExt, WidgetExt};
use gtk::{gio, StringObject};
use re_set_lib::bluetooth::bluetooth_structures::{BluetoothAdapter, BluetoothDevice};
use re_set_lib::signals::{BluetoothDeviceAdded, BluetoothDeviceChanged, BluetoothDeviceRemoved};
use re_set_lib::{
bluetooth::bluetooth_structures::{BluetoothAdapter, BluetoothDevice},
signals::{BluetoothDeviceAdded, BluetoothDeviceChanged, BluetoothDeviceRemoved},
ERROR
};

#[cfg(debug_assertions)]
use re_set_lib::{utils::macros::ErrorLevel, write_log_to_file};

use crate::components::base::error_impl::{show_error, ReSetErrorImpl};
use crate::components::base::utils::Listeners;
Expand Down Expand Up @@ -318,23 +324,32 @@ pub fn start_bluetooth_listener(listeners: Arc<Listeners>, bluetooth_box: Arc<Bl
device_added_handler(device_added_box.clone(), ir)
});
if res.is_err() {
println!("fail on bluetooth device add event");
ERROR!(
"fail on bluetooth device add event",
ErrorLevel::PartialBreakage
);
return;
}

let res = conn.add_match(device_removed, move |ir: BluetoothDeviceRemoved, _, _| {
device_removed_handler(device_removed_box.clone(), ir)
});
if res.is_err() {
println!("fail on bluetooth device remove event");
ERROR!(
"fail on bluetooth device remove event",
ErrorLevel::PartialBreakage
);
return;
}

let res = conn.add_match(device_changed, move |ir: BluetoothDeviceChanged, _, _| {
device_changed_handler(device_changed_box.clone(), ir)
});
if res.is_err() {
println!("fail on bluetooth device remove event");
ERROR!(
"fail on bluetooth device remove event",
ErrorLevel::PartialBreakage
);
return;
}

Expand Down
37 changes: 29 additions & 8 deletions src/components/wifi/wifi_box.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,15 @@ use glib::{clone, ControlFlow};
use gtk::glib::Variant;
use gtk::prelude::ActionableExt;
use gtk::{gio, StringList, StringObject};
use re_set_lib::network::network_structures::{AccessPoint, WifiDevice};
use re_set_lib::signals::{AccessPointAdded, WifiDeviceChanged, WifiDeviceReset};
use re_set_lib::signals::{AccessPointChanged, AccessPointRemoved};
use re_set_lib::{
network::network_structures::{AccessPoint, WifiDevice},
signals::{AccessPointAdded, WifiDeviceChanged, WifiDeviceReset},
signals::{AccessPointChanged, AccessPointRemoved},
ERROR,
};

#[cfg(debug_assertions)]
use re_set_lib::{utils::macros::ErrorLevel, write_log_to_file};

use crate::components::wifi::wifi_box_impl;
use crate::components::wifi::wifi_entry::WifiEntry;
Expand Down Expand Up @@ -324,35 +330,50 @@ pub fn start_event_listener(listeners: Arc<Listeners>, wifi_box: Arc<WifiBox>) {
access_point_added_handler(added_ref.clone(), ir)
});
if res.is_err() {
println!("fail on access point add event");
ERROR!(
"fail on access point add event",
ErrorLevel::PartialBreakage
);
return;
}
let res = conn.add_match(access_point_removed, move |ir: AccessPointRemoved, _, _| {
access_point_removed_handler(removed_ref.clone(), ir)
});
if res.is_err() {
println!("fail on access point remove event");
ERROR!(
"fail on access point remove event",
ErrorLevel::PartialBreakage
);
return;
}
let res = conn.add_match(access_point_changed, move |ir: AccessPointChanged, _, _| {
access_point_changed_handler(changed_ref.clone(), ir)
});
if res.is_err() {
println!("fail on access point change event");
ERROR!(
"fail on access point change event",
ErrorLevel::PartialBreakage
);
return;
}
let res = conn.add_match(device_changed, move |ir: WifiDeviceChanged, _, _| {
wifi_device_changed_handler(wifi_changed_ref.clone(), ir)
});
if res.is_err() {
println!("fail on wifi device change event");
ERROR!(
"fail on wifi device change event",
ErrorLevel::PartialBreakage
);
return;
}
let res = conn.add_match(devices_reset, move |ir: WifiDeviceReset, _, _| {
wifi_device_reset_handler(wifi_reset_ref.clone(), ir)
});
if res.is_err() {
println!("fail on wifi device change event");
ERROR!(
"fail on wifi device change event",
ErrorLevel::PartialBreakage
);
return;
}

Expand Down
23 changes: 20 additions & 3 deletions src/components/window/reset_window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,10 @@ impl ReSetWindow {
let mut plugin_sidebar_list = vec![];
unsafe {
for plugin in FRONTEND_PLUGINS.iter() {

let plugin_capabilities = &plugin.capabilities;

(plugin.frontend_startup)();

let (sidebar_info, plugin_boxes) = (plugin.frontend_data)();
let listeners = self_imp.listeners.clone();

Expand Down Expand Up @@ -241,6 +240,17 @@ impl ReSetWindow {
})
.build();

let banner_action = ActionEntry::builder("banner")
.parameter_type(Some(&String::static_variant_type()))
.activate(move |window: &Self, _, text| {
let imp = window.imp();
if let Some(text) = text {
imp.reset_banner.set_title(&text.to_string());
}
imp.reset_banner.set_revealed(true);
})
.build();

let close_action = ActionEntry::builder("close")
.activate(move |window: &Self, _, _| {
window.close();
Expand Down Expand Up @@ -320,6 +330,7 @@ impl ReSetWindow {

self.add_action_entries([
search_action,
banner_action,
close_action,
about_action,
vim_up,
Expand Down Expand Up @@ -385,6 +396,12 @@ fn setup_callback(window: Rc<ReSetWindow>) -> Rc<ReSetWindow> {
self_imp.reset_close.connect_clicked(move |_| {
close_ref.close();
});

self_imp.reset_banner.connect_button_clicked(|banner| {
banner.set_revealed(false);
banner.set_title("Info");
});

window
}

Expand Down
10 changes: 10 additions & 0 deletions src/components/window/reset_window_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ pub struct ReSetWindow {
#[template_child]
pub reset_main: TemplateChild<FlowBox>,
#[template_child]
pub reset_banner: TemplateChild<adw::Banner>,
#[template_child]
pub reset_sidebar_breakpoint: TemplateChild<Breakpoint>,
#[template_child]
pub reset_overlay_split_view: TemplateChild<OverlaySplitView>,
Expand All @@ -36,6 +38,8 @@ pub struct ReSetWindow {
pub reset_sidebar_toggle: TemplateChild<Button>,
#[template_child]
pub reset_close: TemplateChild<Button>,
// #[template_child]
// pub reset_banner: TemplateChild<adw::Banner>,
pub sidebar_entries: SidebarEntries,
pub default_entry: RefCell<Option<Rc<SidebarEntry>>>,
pub listeners: Arc<Listeners>,
Expand Down Expand Up @@ -81,14 +85,20 @@ impl WidgetImpl for ReSetWindow {
if width > 658 {
self.reset_main.set_margin_start(60);
self.reset_main.set_margin_end(60);
self.reset_banner.set_margin_start(60);
self.reset_banner.set_margin_end(60);
} else {
let div = (width - 540) / 2;
if div > 1 {
self.reset_main.set_margin_start(div);
self.reset_main.set_margin_end(div);
self.reset_banner.set_margin_start(div);
self.reset_banner.set_margin_end(div);
} else {
self.reset_main.set_margin_start(0);
self.reset_main.set_margin_end(0);
self.reset_banner.set_margin_start(0);
self.reset_banner.set_margin_end(0);
}
}
}
Expand Down
Loading

0 comments on commit 8466008

Please sign in to comment.