Code

[RWRoute] Yet more cleanup#1107

Code

Merged

eddieh-xlnx merged 107 commits intomasterXilinx/RapidWright:masterfrom rwroute_cleanup2Xilinx/RapidWright:rwroute_cleanup2Copy head branch name to clipboardNov 19, 2024

+547-442

Commits

Commits on Oct 4, 2024

• Tighten TestRWRoute.testSLRCrossingNonTimingDriven()

  Show description for 1298a39
  eddieh-xlnx

  committed
  1298a39

  Copy full SHA for 1298a39

Commits on Oct 5, 2024

• [RWRoute] Tidy up, no functional change

  Show description for a206c2c
  eddieh-xlnx

  committed
  a206c2c

  Copy full SHA for a206c2c

• [RWRoute] Fix SLR crossing distance estimation

  Show description for ccdddee
  eddieh-xlnx

  committed
  ccdddee

  Copy full SHA for ccdddee

• Remove unused RouteNode.driverCounts; down from 80 -> 72 bytes

  Show description for 4c1546b
  eddieh-xlnx

  committed
  4c1546b

  Copy full SHA for 4c1546b

• Update another test

  Show description for 69a22c1
  eddieh-xlnx

  committed
  69a22c1

  Copy full SHA for 69a22c1

• Remove unused import

  Show description for d8afb12
  eddieh-xlnx

  committed
  d8afb12

  Copy full SHA for d8afb12

• [RouteNodeGraph] Limit size of preservedMap/nodesMap value array

  Show description for ec288a1
  eddieh-xlnx

  committed
  ec288a1

  Copy full SHA for ec288a1

• [PartialRouter] unpreserveNet() to return new NetWrapper

  Show description for a3bc056
  eddieh-xlnx

  committed
  a3bc056

  Copy full SHA for a3bc056

• [PartialRouter] When overused sinks found, unroute on top of unpreserving

  Show description for 008377f
  eddieh-xlnx

  committed
  008377f

  Copy full SHA for 008377f

• Add asserts, remove ripUp()

  Show description for 36c9e43
  eddieh-xlnx

  committed
  36c9e43

  Copy full SHA for 36c9e43

• [RWRoute] ripUp() to not release exclusive sink nodes

  Show description for 728b983
  eddieh-xlnx

  committed
  728b983

  Copy full SHA for 728b983

• Fix spacing

  Show description for fbccb34
  eddieh-xlnx

  committed
  fbccb34

  Copy full SHA for fbccb34

• Fix broken cherry-pick

  Show description for 22decc1
  eddieh-xlnx

  committed
  22decc1

  Copy full SHA for 22decc1

• Remove commented out code

  Show description for ad76a4e
  eddieh-xlnx

  committed
  ad76a4e

  Copy full SHA for ad76a4e

• Sink is only exclusive if no alt sinks

  Show description for fd88782
  eddieh-xlnx

  committed
  fd88782

  Copy full SHA for fd88782

• RouteNode from 72 bytes to 64; use array/AtomicReferenceArray for ...

  Show description for e82e56a
  eddieh-xlnx

  committed
  e82e56a

  Copy full SHA for e82e56a

• Add and use Connection.hasAltSinks()

  Show description for 8c5c6e8
  eddieh-xlnx

  committed
  8c5c6e8

  Copy full SHA for 8c5c6e8

• Fix sink rip up, tidy

  Show description for e91ed20
  eddieh-xlnx

  committed
  e91ed20

  Copy full SHA for e91ed20

Commits on Oct 6, 2024

• Fix assertions for alternate sinks

  Show description for 0bb302b
  eddieh-xlnx

  committed
  0bb302b

  Copy full SHA for 0bb302b

• Use Net.addPIP() for trackChanges()

  Show description for b5d16c7
  eddieh-xlnx

  committed
  b5d16c7

  Copy full SHA for b5d16c7

• [DesignTools] Cleanup createCeSrRstPinsToVCC()

  Show description for 037584c
  eddieh-xlnx

  committed
  037584c

  Copy full SHA for 037584c

Commits on Oct 7, 2024

• [RouteNode] setBaseCost() to be more robust

  Show description for 3160382
  eddieh-xlnx

  committed
  3160382

  Copy full SHA for 3160382

• Mark zero-length nodes with downhill PIP as being inaccessible

  Show description for e7b8d6e
  eddieh-xlnx

  committed
  e7b8d6e

  Copy full SHA for e7b8d6e

• Only warn about RCLKs if timing-driven

  Show description for ef66def
  eddieh-xlnx

  committed
  ef66def

  Copy full SHA for ef66def

• Do not add as child if INACCESSIBLE

  Show description for bf1593d
  eddieh-xlnx

  committed
  bf1593d

  Copy full SHA for bf1593d

• Update golden values

  Show description for 6821a07
  eddieh-xlnx

  committed
  6821a07

  Copy full SHA for 6821a07

• [DesignTools] Fix createCeSrRstPinsToVCC() for US BRAMs

  Show description for f9069d1
  eddieh-xlnx

  committed
  f9069d1

  Copy full SHA for f9069d1

• Apply suggestions from code review

  Show description for 790e797
  eddieh-xlnx

  authored
  790e797

  Copy full SHA for 790e797

• [DesignTools] Add LDCE/LDPE to flop types that need site pins

  Show description for d4e94b7
  eddieh-xlnx

  committed
  d4e94b7

  Copy full SHA for d4e94b7

• Ignore rnodes created before iteration 0, make abandoning message clearer

  Show description for 07d8f12
  eddieh-xlnx

  committed
  07d8f12

  Copy full SHA for 07d8f12

Commits on Oct 23, 2024

• Merge branch 'master' into rwroute_cleanup2

  Show description for ab908c2
  eddieh-xlnx

  committed
  ab908c2

  Copy full SHA for ab908c2

• RouteNodeGraph.allowRoutethru() to ignore NODE_PINFEED targets

  Show description for d9927c2
  eddieh-xlnx

  committed
  d9927c2

  Copy full SHA for d9927c2

• Add comment

  Show description for e00bd91
  eddieh-xlnx

  committed
  e00bd91

  Copy full SHA for e00bd91

Commits on Nov 4, 2024

• Add optimization of signal routing

  Show description for f89c96e
  WenhaoLin-AMD

  committed
  f89c96e

  Copy full SHA for f89c96e

• Merge new method into RoutingGraph.isAccessible()

  Show description for 57f39df
  eddieh-xlnx

  committed
  57f39df

  Copy full SHA for 57f39df

• Fix typo

  Show description for 74df324
  eddieh-xlnx

  committed
  74df324

  Copy full SHA for 74df324

• Add TestNode.testNodeReachabilityVersal() to check assumptions

  Show description for 3bf9cb9
  eddieh-xlnx

  committed
  3bf9cb9

  Copy full SHA for 3bf9cb9

• Add NODE_CLE_OUTPUT too

  Show description for bf4d076
  eddieh-xlnx

  committed
  bf4d076

  Copy full SHA for bf4d076

• Expand TestNode.testNodeReachabilityUltraScale()

  Show description for 1f8a9d3
  eddieh-xlnx

  committed
  1f8a9d3

  Copy full SHA for 1f8a9d3

Commits on Nov 5, 2024

• More

  Show description for bba91e1
  eddieh-xlnx

  committed
  bba91e1

  Copy full SHA for bba91e1

• Add and use RouteNodeType.LOCAL

  Show description for 4356b03
  eddieh-xlnx

  committed
  4356b03

  Copy full SHA for 4356b03

• Merge RouteNodeType.PINBOUNCE into LOCAL; rename WIRE, PINFEED_{I,O}

  Show description for 7e7015a
  eddieh-xlnx

  committed
  7e7015a

  Copy full SHA for 7e7015a

• LUT routethru fixes

  Show description for b9ff45f
  eddieh-xlnx

  committed
  b9ff45f

  Copy full SHA for b9ff45f

• Add testNodeReachabilityVersal()

  Show description for aabab3c
  eddieh-xlnx

  committed
  aabab3c

  Copy full SHA for aabab3c

• Support UltraScale

  Show description for 9929603
  eddieh-xlnx

  committed
  9929603

  Copy full SHA for 9929603

• Merge branch 'us_node_reach' into signal_router_optimize_eh

  eddieh-xlnx

  committed
  e47cd18

  Copy full SHA for e47cd18

• Extend RouteNodeType.LOCAL to Versal

  Show description for 9aba0ac
  eddieh-xlnx

  committed
  9aba0ac

  Copy full SHA for 9aba0ac

• Exclude Versal's NODE_IMUX/NODE_{CLE,INTF}_CTRL if not in RRG

  Show description for c197f08
  eddieh-xlnx

  committed
  c197f08

  Copy full SHA for c197f08

Commits on Nov 6, 2024

• Merge branch 'master' into signal_router_optimize

  Show description for 9717cd4
  eddieh-xlnx

  committed
  9717cd4

  Copy full SHA for 9717cd4

Commits on Nov 7, 2024

• More explanatory approach; no difference

  Show description for 7274b33
  eddieh-xlnx

  committed
  7274b33

  Copy full SHA for 7274b33

• Improvement?

  Show description for 14955fe
  eddieh-xlnx

  committed
  14955fe

  Copy full SHA for 14955fe

• Cleanup

  Show description for 56afd4b
  eddieh-xlnx

  committed
  56afd4b

  Copy full SHA for 56afd4b

• Update comments

  Show description for cac787e
  eddieh-xlnx

  committed
  cac787e

  Copy full SHA for cac787e

• Add NODE_INTF_{CNODE,BNODE}

  Show description for ef4227c
  eddieh-xlnx

  committed
  ef4227c

  Copy full SHA for ef4227c

Commits on Nov 12, 2024

• [TestNode] Expand testNodeReachabilityUltraScale

  Show description for cd631ac
  eddieh-xlnx

  committed
  cd631ac

  Copy full SHA for cd631ac

• Expand testNodeReachabilityVersal too

  Show description for 038aa80
  eddieh-xlnx

  committed
  038aa80

  Copy full SHA for 038aa80

• UltraScale+: Sub-divide LOCALs into _EAST/_WEST and stick to sink's side

  Show description for 77fa308
  eddieh-xlnx

  committed
  77fa308

  Copy full SHA for 77fa308

• Re-add EXCLUSIVE_SINK (non-sided) for CTRL sinks

  Show description for 6229dbe
  eddieh-xlnx

  committed
  6229dbe

  Copy full SHA for 6229dbe

• Support UltraScale

  Show description for 74fdf59
  eddieh-xlnx

  committed
  74fdf59

  Copy full SHA for 74fdf59

• Print

  Show description for a1dca37
  eddieh-xlnx

  committed
  a1dca37

  Copy full SHA for a1dca37

• Expand testNodeReachabilityVersal

  Show description for 977b068
  eddieh-xlnx

  committed
  977b068

  Copy full SHA for 977b068

• Do not error out for Versal

  Show description for 967890d
  eddieh-xlnx

  committed
  967890d

  Copy full SHA for 967890d

• Fix failing assertions

  Show description for 9a48765
  eddieh-xlnx

  committed
  9a48765

  Copy full SHA for 9a48765

• Remove unused import

  Show description for 95bba95
  eddieh-xlnx

  committed
  95bba95

  Copy full SHA for 95bba95

• Fix another typo

  Show description for 3a25ead
  eddieh-xlnx

  committed
  3a25ead

  Copy full SHA for 3a25ead

• Fix SLR crossings

  Show description for 0d60f48
  eddieh-xlnx

  committed
  0d60f48

  Copy full SHA for 0d60f48

• More Versal fixes

  Show description for d4e0ea5
  eddieh-xlnx

  committed
  d4e0ea5

  Copy full SHA for d4e0ea5

• Update testSLRCrossingNonTimingDriven golden values

  Show description for 07935a4
  eddieh-xlnx

  committed
  07935a4

  Copy full SHA for 07935a4

• Tidy up and comments

  Show description for bb9db76
  eddieh-xlnx

  committed
  bb9db76

  Copy full SHA for bb9db76

• Add a few more testcases

  Show description for 9e7d383
  eddieh-xlnx

  committed
  9e7d383

  Copy full SHA for 9e7d383

• [RWRoute] Non-verbose mode to print out nodes popped

  Show description for 4f43cf5
  eddieh-xlnx

  committed
  4f43cf5

  Copy full SHA for 4f43cf5

• Update comments/asserts

  Show description for 7890b5a
  eddieh-xlnx

  committed
  7890b5a

  Copy full SHA for 7890b5a

• Clean up RouteNodeGraph.isAccessible()

  Show description for 15b7453
  eddieh-xlnx

  committed
  15b7453

  Copy full SHA for 15b7453

• Fixes for UltraScale

  Show description for b61a199
  eddieh-xlnx

  committed
  b61a199

  Copy full SHA for b61a199

• Skip another assert for Versal

  Show description for a937982
  eddieh-xlnx

  committed
  a937982

  Copy full SHA for a937982

• Merge branch 'master' into signal_router_optimize

  eddieh-xlnx

  committed
  da6c175

  Copy full SHA for da6c175

• Merge branch 'rwroute_east_west' into signal_router_optimize

  Show description for 6f0b9ae
  eddieh-xlnx

  committed
  6f0b9ae

  Copy full SHA for 6f0b9ae

• Fix Versal assertion

  Show description for b07f2db
  eddieh-xlnx

  committed
  b07f2db

  Copy full SHA for b07f2db

• Fix assertion

  Show description for 90e8d80
  eddieh-xlnx

  committed
  90e8d80

  Copy full SHA for 90e8d80

• Expand test

  Show description for bdf791f
  eddieh-xlnx

  committed
  bdf791f

  Copy full SHA for bdf791f

Commits on Nov 13, 2024

• Apply #1098 to Versal too

  Show description for c1e8274
  eddieh-xlnx

  committed
  c1e8274

  Copy full SHA for c1e8274

• Assign CNODEs to be LOCAL_{EAST,WEST} (opposite to name)

  Show description for 50287fe
  eddieh-xlnx

  committed
  50287fe

  Copy full SHA for 50287fe

• Merge branch 'master' into signal_router_optimize

  eddieh-xlnx

  committed
  b048ef3

  Copy full SHA for b048ef3

• Fix merge

  Show description for f4df052
  eddieh-xlnx

  committed
  f4df052

  Copy full SHA for f4df052

• Resolve FIXMEs

  Show description for 003a051
  eddieh-xlnx

  committed
  003a051

  Copy full SHA for 003a051

• Restore comment

  Show description for c057226
  eddieh-xlnx

  committed
  c057226

  Copy full SHA for c057226

• Fix continue

  Show description for 353775c
  eddieh-xlnx

  committed
  353775c

  Copy full SHA for 353775c

• On Versal, make all NODE_PINFEEDs RouteNodeType.LOCAL

  Show description for a9f5161
  eddieh-xlnx

  committed
  a9f5161

  Copy full SHA for a9f5161

• Handle NODE_INTF_CNODE too

  Show description for 76bc5cc
  eddieh-xlnx

  committed
  76bc5cc

  Copy full SHA for 76bc5cc

• Add comment

  Show description for 7b190bf
  eddieh-xlnx

  committed
  7b190bf

  Copy full SHA for 7b190bf

• Simplify if

  Show description for e877503
  eddieh-xlnx

  committed
  e877503

  Copy full SHA for e877503

• Introduce LOCAL_RESERVED

  Show description for ce90eb7
  eddieh-xlnx

  committed
  ce90eb7

  Copy full SHA for ce90eb7

• Allow INODE and PINBOUNCE either side of CTRL sink to be used

  Show description for 1c2b471
  eddieh-xlnx

  committed
  1c2b471

  Copy full SHA for 1c2b471

• Update comment

  Show description for 5414206
  eddieh-xlnx

  committed
  5414206

  Copy full SHA for 5414206

• Clearer names

  Show description for 57ed051
  eddieh-xlnx

  committed
  57ed051

  Copy full SHA for 57ed051

• Fix

  Show description for 8c0acba
  eddieh-xlnx

  committed
  8c0acba

  Copy full SHA for 8c0acba

• Tidy up

  Show description for d1e843a
  eddieh-xlnx

  committed
  d1e843a

  Copy full SHA for d1e843a

Commits on Nov 14, 2024

• Merge branch 'master' into signal_router_optimize

  Show description for fb08d82
  eddieh-xlnx

  committed
  fb08d82

  Copy full SHA for fb08d82

• Merge branch 'signal_router_optimize' into rwroute_cleanup2

  Show description for 3bfcdf4
  eddieh-xlnx

  committed
  3bfcdf4

  Copy full SHA for 3bfcdf4

• Cleanup

  Show description for 1ebc503
  eddieh-xlnx

  committed
  1ebc503

  Copy full SHA for 1ebc503

• Reduce SLR crossing goldens

  Show description for 0cf3118
  eddieh-xlnx

  committed
  0cf3118

  Copy full SHA for 0cf3118

• Reduce one more

  Show description for c207dbc
  eddieh-xlnx

  committed
  c207dbc

  Copy full SHA for c207dbc

• More accurate message

  Show description for 0b57ffa
  eddieh-xlnx

  committed
  0b57ffa

  Copy full SHA for 0b57ffa

• Simplify and comment

  Show description for 062e4d9
  eddieh-xlnx

  committed
  062e4d9

  Copy full SHA for 062e4d9

Commits on Nov 18, 2024

• Merge branch 'master' into rwroute_cleanup2

  Show description for 88145ed
  eddieh-xlnx

  committed
  88145ed

  Copy full SHA for 88145ed

• Update src/com/xilinx/rapidwright/rwroute/PartialRouter.java

  Show description for 425b0b7
  eddieh-xlnx

  authored
  425b0b7

  Copy full SHA for 425b0b7

• Add two testcases that needed fixing (requires Vivado)

  Show description for c9ec130
  eddieh-xlnx

  committed
  c9ec130

  Copy full SHA for c9ec130