[RWRoute] Check source & sink pin reaches INT tile for dedicated connections #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
This reverts commit 0f42189. Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
…nections Signed-off-by: Eddie Hung <[email protected]>
…_fix Conflicts: test/src/com/xilinx/rapidwright/rwroute/TestRWRoute.java
clavin-xlnx
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, RWRoute would assume that if the sink pin cannot reach the INT tile, then it must be a dedicated connection.
I've encountered a case (
BUFG_GT_X0Y78/CLK_IN) where the sink pin can reach the INT tile, but the source pin (GTYE4_CHANNEL_X0Y12/TXOUTCLK_INT) cannot.Fix it so that both source (and alternate sources) and sink pins are checked for INT reachability before declaring it is not a dedicated connection.