Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebook examples deterministic #842

Closed
nickfraser opened this issue Feb 13, 2024 · 2 comments · Fixed by #847
Closed

Make notebook examples deterministic #842

nickfraser opened this issue Feb 13, 2024 · 2 comments · Fixed by #847
Assignees
Labels
good first issue Good for newcomers

Comments

@nickfraser
Copy link
Collaborator

Some cells have a seed set, but we need to do this everywhere where it's necessary. This would make it much easier to verify them with a script.

@nickfraser nickfraser added the good first issue Good for newcomers label Feb 13, 2024
@fabianandresgrob fabianandresgrob self-assigned this Feb 13, 2024
@fabianandresgrob
Copy link
Collaborator

As torch.manual_seed() is creating a generator, it should be sufficient to set it once at the start of each notebook.
Or does a seed per cell (given that any numbers are generated) have any other advantages?

@nickfraser
Copy link
Collaborator Author

Start of the notebook should be fine, but we shouldn't change the cells where it is set explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants