-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebooks: makes notebooks deterministic and prints output of asserts #847
Conversation
Can you test the following:
I have a small script to run the notebooks like so: #!/bin/bash
# source: https://mljar.com/blog/run-jupyter-notebook-command-line/
for f in *.ipynb; do
cp $f $f.orig
jupyter nbconvert --execute --allow-errors --to notebook --inplace $f
echo nbdiff-web -b /dev/null $f.orig $f
done My goal is that when you compare with |
Checked using that script, everything looks good. Only minor things differ like kernel id. I added one more |
When doing multiple runs to compare, restart the kernels, just to be sure |
50ef9a0
to
468b98b
Compare
61214f3
to
f1b04a5
Compare
Rebase please |
f1b04a5
to
858f81b
Compare
858f81b
to
74883d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR for #842 and #843