HQO for scale/zero point #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
commented
Apr 17, 2024
| candidate[torch.isnan(candidate)] = self.internal_candidate[torch.isnan(candidate)] | ||
| candidate = self.clamp_min_ste(candidate) | ||
| bit_width = self.msb_clamp_bit_width_impl() | ||
| int_threshold = self.int_scaling_impl(bit_width) |
There was a problem hiding this comment.
Int specific implementation, maybe it should be generalized to also cover minifloat case
There was a problem hiding this comment.
maybe it should be generalized to also cover minifloat case
This looks like it hasn't been resolved to me. Is that true?
Giuseppe5
commented
Apr 17, 2024
Giuseppe5
force-pushed
the
hqo
branch
2 times, most recently
from
47c9f88
to
5cc7648
Compare
nickfraser
added
the
next release
Giuseppe5
commented
Aug 21, 2024
nickfraser
reviewed
Sep 4, 2024
| candidate[torch.isnan(candidate)] = self.internal_candidate[torch.isnan(candidate)] | ||
| candidate = self.clamp_min_ste(candidate) | ||
| bit_width = self.msb_clamp_bit_width_impl() | ||
| int_threshold = self.int_scaling_impl(bit_width) |
There was a problem hiding this comment.
maybe it should be generalized to also cover minifloat case
This looks like it hasn't been resolved to me. Is that true?
Giuseppe5
requested review from
nickfraser
and removed request for
nickfraser
Giuseppe5
requested review from
nickfraser
and removed request for
nickfraser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement HQO optimization for scale and zero point.
Caveats:
Maybe worth to merge after #1002 and expand tests