Feat (gpfq): separate float and quant forward pass for speedup #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianandresgrob
force-pushed
the
gpfq_offload_float_acts
branch
2 times, most recently
from
bece0c6
to
9d886c0
Compare
fabianandresgrob
force-pushed
the
gpfq_offload_float_acts
branch
from
a5e4405
to
bbc025c
Compare
fabianandresgrob
force-pushed
the
gpfq_offload_float_acts
branch
from
af9c229
to
9f6ade9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeding up GPFQ with separate forward passes for quantized and float input. I avoided offloading the float input to disc and instead saved them under an attribute for GPFQ and simply moved them off the GPU when collected.