Fix Documentation Sequence Interfering with Liquid Templating #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrej
requested review from
makslevental,
jgmelber and
AndraBisca
as code owners
AndraBisca
approved these changes
Jul 10, 2024
|
Don't know why that matrix multiplication design test is failing. This PR leaves it unchanged and the tests have been passing up to this point. How do I restart the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at getting the online documentation to build and deploy again.
This is a band-aid fix. Issue #1604 should still be properly addressed by properly automatically escaping "{%" sequences in our documentation even if this ends up fixing it for now.
There is almost certainly no use for us to use Liquid templating in our documentation strings, but stuff like "{%tile_0_0}" is almost inveitably bound to show up again, and the next person to add it might not know that they need to escape it.