[WIP] Enable init values for Object FIFO #1813
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -591,6 +610,46 @@ void printObjectFifoConsumerTiles(OpAsmPrinter &printer, Operation *op, | |||
| } | |||
| } | |||
|
|
|||
| static void printObjectFifoInitValues(OpAsmPrinter &p, ObjectFifoCreateOp op, | |||
| Attribute numElem, TypeAttr type, Attribute initValues) { | |||
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| Attribute numElem, TypeAttr type, Attribute initValues) { | |
| Attribute numElem, TypeAttr type, | |
| Attribute initValues) { |
Comment on lines
+621
to
+622
| static ParseResult parseObjectFifoInitValues(OpAsmParser &parser, Attribute numElem, | ||
| TypeAttr type, Attribute &initValues) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| static ParseResult parseObjectFifoInitValues(OpAsmParser &parser, Attribute numElem, | |
| TypeAttr type, Attribute &initValues) { | |
| static ParseResult parseObjectFifoInitValues(OpAsmParser &parser, | |
| Attribute numElem, TypeAttr type, | |
| Attribute &initValues) { |
| TypeAttr type, Attribute &initValues) { | ||
| int64_t depth; | ||
| if (isa<ArrayAttr>(numElem)) { | ||
| depth = llvm::dyn_cast<mlir::IntegerAttr>(llvm::dyn_cast<mlir::ArrayAttr>(numElem)[0]).getInt(); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| depth = llvm::dyn_cast<mlir::IntegerAttr>(llvm::dyn_cast<mlir::ArrayAttr>(numElem)[0]).getInt(); | |
| depth = llvm::dyn_cast<mlir::IntegerAttr>( | |
| llvm::dyn_cast<mlir::ArrayAttr>(numElem)[0]) | |
| .getInt(); |
| std::vector<int64_t> newShape = {depth}; | ||
| for (auto d : shape) | ||
| newShape.push_back(d); | ||
| auto memrefType = MemRefType::get(ArrayRef(newShape), memrefTypeNoDepth.getElementType()); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto memrefType = MemRefType::get(ArrayRef(newShape), memrefTypeNoDepth.getElementType()); | |
| auto memrefType = | |
| MemRefType::get(ArrayRef(newShape), memrefTypeNoDepth.getElementType()); |
Comment on lines
330
to
+331
| auto prodLock = builder.create<LockOp>( | ||
| builder.getUnknownLoc(), creation_tile, prodLockID, numElem); | ||
| builder.getUnknownLoc(), creation_tile, prodLockID, numElem - initValues.size()); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto prodLock = builder.create<LockOp>( | |
| builder.getUnknownLoc(), creation_tile, prodLockID, numElem); | |
| builder.getUnknownLoc(), creation_tile, prodLockID, numElem - initValues.size()); | |
| auto prodLock = | |
| builder.create<LockOp>(builder.getUnknownLoc(), creation_tile, | |
| prodLockID, numElem - initValues.size()); |
Comment on lines
339
to
+340
| auto consLock = builder.create<LockOp>(builder.getUnknownLoc(), | ||
| creation_tile, consLockID, 0); | ||
| creation_tile, consLockID, initValues.size()); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto consLock = builder.create<LockOp>(builder.getUnknownLoc(), | |
| creation_tile, consLockID, 0); | |
| creation_tile, consLockID, initValues.size()); | |
| auto consLock = | |
| builder.create<LockOp>(builder.getUnknownLoc(), creation_tile, | |
| consLockID, initValues.size()); |
| if (!creation_tile.isShimTile()) { | ||
| if (op.getInitValues().has_value()) { | ||
| initValues = builder.getI32VectorAttr(ArrayRef(op.getInitialValues()[i])); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| initValues = builder.getI32VectorAttr(ArrayRef(op.getInitialValues()[i])); | |
| initValues = | |
| builder.getI32VectorAttr(ArrayRef(op.getInitialValues()[i])); |
| if (!createOp.getInitValues().has_value()) { | ||
| int prodMaxAcquire = findObjectFifoSize( | ||
| device, createOp.getProducerTileOp(), createOp); | ||
| createOp.setElemNumberAttr(builder.getI32IntegerAttr(prodMaxAcquire)); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| createOp.setElemNumberAttr(builder.getI32IntegerAttr(prodMaxAcquire)); | |
| createOp.setElemNumberAttr( | |
| builder.getI32IntegerAttr(prodMaxAcquire)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.