Add quick_setup.sh test to github action #1835
Conversation
| pip cache purge | ||
| source /opt/xilinx/xrt/setup.sh | ||
| python -m pip install virtualenv |
There was a problem hiding this comment.
Other workflows use venv. It is already installed, is part of python, and does not pip install anything to the github user's site packages.
There was a problem hiding this comment.
Makes sense to me! I've changed quick_setup to use venv instead of virtualenv.
There was a problem hiding this comment.
Makes sense to me! I've changed quick_setup to use venv instead of virtualenv.
Note it was slightly religious statement I made (venv over virtualenv). There may be cases where virtualenv is less friction because ubuntu doesn't install venv by default and user might not have sudo to apt install it.
There was a problem hiding this comment.
I don't have a strong preference either way (venv vs virtualenv), but I think it makes sense to be consistent. Is there anyone else who may want to weigh in? Otherwise, I'll stick to changes to venv.
… and will need to be reverted
hunhoffe
requested review from
jackl-xilinx,
jgmelber and
stephenneuendorffer
as code owners
Test the
quick_setup.shenvironment/build using the programming examples and programming guide on Ryzen AI.