Skip to content

Commit

Permalink
Merge pull request #177 from Xilinx/matthias.update_stable
Browse files Browse the repository at this point in the history
Update torch stable to 2.3.1
  • Loading branch information
mgehre-amd authored Jul 9, 2024
2 parents eab02e0 + a679504 commit 25b11b2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 20 deletions.
7 changes: 0 additions & 7 deletions projects/pt1/e2e_testing/xfail_sets.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
from torch_mlir_e2e_test.test_suite import COMMON_TORCH_MLIR_LOWERING_XFAILS
from torch_mlir._version import torch_version_for_comparison, version

print(f"TORCH_VERSION_FOR_COMPARISON =", torch_version_for_comparison())

LINALG_XFAIL_SET = COMMON_TORCH_MLIR_LOWERING_XFAILS | {
"Conv1dNoPaddingGroupModule_basic",
"RepeatInterleaveStaticModule_basic",
Expand Down Expand Up @@ -352,11 +350,6 @@
"InterpolateDynamicModule_scales_recompute_bilinear",
}

if torch_version_for_comparison() <= version.parse("2.2.0"):
TORCHDYNAMO_XFAIL_SET |= {
'OneHotModule_basic',
}

TORCHDYNAMO_CRASHING_SET = {
# No upstream decompositions.
# %6:4 = torch.operator "aten._embedding_bag_forward_only"(%1, %3, %5, %false, %int0, %false, %none, %false, %int-1) : (!torch.tensor<*,f32>, !torch.tensor<*,si64>, !torch.tensor<*,si64>, !torch.bool, !torch.int, !torch.bool, !torch.none, !torch.bool, !torch.int) -> (!torch.tensor, !torch.tensor, !torch.tensor, !torch.tensor)
Expand Down
4 changes: 1 addition & 3 deletions projects/pt1/python/torch_mlir/dynamo.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def _get_decomposition_table():
# (the upstream decomposition we use here does), even though we have
# support for aten.native_batch_norm_backward.
aten._native_batch_norm_legit_functional,
aten._native_batch_norm_legit_no_training,
aten.native_group_norm,
aten.split.Tensor,
aten.split_with_sizes,
Expand All @@ -67,9 +68,6 @@ def _get_decomposition_table():
aten.cumsum,
aten.index_select,
]
# TODO: enable test once 2.1.0 is stable
if torch_version_for_comparison() >= version.parse("2.1.0.dev"):
decomp_list += [aten._native_batch_norm_legit_no_training]
return get_decompositions(decomp_list)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@
"ElementwiseToDtypeI64ToUI8Module_basic",
}

# TODO: Delete once torch 2.1.0 is released
if torch_version_for_comparison() < version.parse("2.1.0.dev"):
COMMON_TORCH_MLIR_LOWERING_XFAILS.update({
"ScaledDotProductAttentionDifferentModule_basic",
"ScaledDotProductAttentionSameModule_basic"
})


def register_all_tests():
"""Registers all the built-in E2E tests that Torch-MLIR provides."""
# Side-effecting import statements.
Expand Down
4 changes: 2 additions & 2 deletions stable-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
--index-url https://download.pytorch.org/whl/cpu
torch==2.1.2+cpu
torchvision==0.16.2+cpu
torch==2.3.1+cpu
torchvision==0.18.1+cpu

0 comments on commit 25b11b2

Please sign in to comment.