Merge pull request #195 from Xilinx/tina.error-out-onnx-op-version-ty…

…pe-mismatch Error out if version has the wrong type
Xilinx · Jul 10, 2024 · 66a48d6 · 66a48d6
2 parents 2f137b6 + d212544
commit 66a48d6
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/Conversion/TorchOnnxToTorch/Patterns.cpp b/lib/Conversion/TorchOnnxToTorch/Patterns.cpp
@@ -33,12 +33,8 @@ LogicalResult OnnxCustomOpConversionPattern::matchAndRewrite(
   // overrides the function's domainVersion and will be used for matching later
   // here.
   if (auto attr = op->getAttrOfType<IntegerAttr>("torch.onnx_meta.version")) {
-    if (auto type = dyn_cast<IntegerType>(attr.getType())) {
-      if (type.isSigned()) {
-        opDomainVersion =
-            op->getAttrOfType<IntegerAttr>("torch.onnx_meta.version").getSInt();
-      }
-    }
+    assert(cast<IntegerType>(attr.getType()).isSigned());
+    opDomainVersion = attr.getSInt();
   }
   auto &reggies = foundIt->second;
   for (const HandlerReg &reg : reggies) {