Import FX graph node name #131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
force-pushed
the
matthias.import_node_debugName
branch
from
57ed408
to
d7d21fa
Compare
mgehre-amd
force-pushed
the
matthias.import_node_debugName
branch
from
d7d21fa
to
983ce1a
Compare
mgehre-amd
force-pushed
the
matthias.import_node_debugName
branch
from
983ce1a
to
f719bf6
Compare
mgehre-amd
force-pushed
the
matthias.import_node_debugName
branch
from
f719bf6
to
caca87b
Compare
|
@cmcgirr-amd, I cleaned this up and added test. I think we can go ahead and merge this. |
|
@mgehre-amd did you add the test here or in another repo? |
Oh shoot, I was thinking about another PR. I will add a test here. |
cmcgirr-amd
reviewed
Aug 11, 2023
|
|
||
| // Whether to add the FXOutputName attribute from the debug name of the jit | ||
| // node. | ||
| bool addFxOutputName = false; |
There was a problem hiding this comment.
In the context of torch-mlir this output name would be the tensor "SSA" name we see in the FX graph right? Maybe its worth mentioning it in the comment.
We have just been filling OutputName with the name of the operation that created the output. Might be confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.