Merge to upstream 798bfd7df #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm#2992 dropped `constraints` from the fx importer API, [breaking](https://github.com/cruise-automation/mlir-tcp/actions/runs/8284385380/job/22669774071) downstream AOT compile tests in `mlir-tcp` that use it. This knob has been soft-deprecated for a while now, replaced by `dynamic_shapes` - a more ergonomic interface. This PR brings back dynamic_shapes constraints in the new supported form. Also added a python lit test with dynamic shaped annotations.
mgehre-amd
reviewed
Jul 24, 2024
mgehre-amd
approved these changes
Jul 24, 2024
mgehre-amd
reviewed
Jul 24, 2024
Co-authored-by: Matthias Gehre <[email protected]>
cferry-AMD
force-pushed
the
corentin.merge_798bfd7df
branch
from
fb4f030
to
9a232db
Compare
|
I squashed my additional commits into a single one for the history to be clean upon merge into our branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest upstream commit that can merge in here without any conflicts or failures. Passing CI requires pinning stable
torchto 2.3.1 that was the stable version at the time of that commit.