Skip to content

Commit

Permalink
[chore] [processor/groupbyattrs] clarify compaction occurs even when …
Browse files Browse the repository at this point in the history
…no key matches (open-telemetry#31027)

I expected the processor to be a complete no-op if no attribute keys
match, but I noticed that it still does perform compaction, as if the
processor was configured with an empty config (no keys). In some sense
it feels like having both grouping and compaction features in one
processor is confusing, but it's not that bad in practice but this doc
clarification can make it less surprising.
  • Loading branch information
anuraaga authored and XinRanZhAWS committed Mar 13, 2024
1 parent 07b8c17 commit 5007f6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion processor/groupbyattrsprocessor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ processors:
The `keys` property describes which attribute keys will be considered for grouping:

* If the processed span, log record and metric data point has at least one of the specified attributes key, it will be moved to a *Resource* with the same value for these attributes. The *Resource* will be created if none exists with the same attributes.
* If none of the specified attributes key is present in the processed span, log record or metric data point, it remains associated to the same *Resource* (no change).
* If none of the specified attributes key is present in the processed span, log record or metric data point, it remains associated to the same *Resource* (no change), with multiple instances of the same *Resource* still [compacted](#compaction).

Please refer to:

Expand Down

0 comments on commit 5007f6f

Please sign in to comment.