Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Qa/workbook 111 ] workbook qa #112

Merged
merged 5 commits into from
Jul 12, 2024
Merged

[ Qa/workbook 111 ] workbook qa #112

merged 5 commits into from
Jul 12, 2024

Conversation

soomin9106
Copy link
Collaborator

🔥 Related Issues

resolve #111
close #111

💜 작업 내용

  • workbook page 진입 시 이메일 팝업 제거
  • 이미 구독한 경우 서버에서 에러 메시지를 내려 toast 에 표시

✅ PR Point

  • 서버에서 이미 구독한 경우 메시지 내려오고 있어서 처리 가능했습니다! 🫡

😡 Trouble Shooting

👀 스크린샷 / GIF / 링크

스크린샷 2024-07-11 오후 10 57 53

@soomin9106 soomin9106 self-assigned this Jul 11, 2024
@@ -43,13 +45,18 @@ export const useSubscribeForm = () => {
});
},
onError: (error) => {
console.error(error);
let errorMessage = '구독 신청이 되지 않았습니다.';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것도 상수로 관리할까요?!

Copy link
Collaborator

@Happhee Happhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팝업 없애니까 훨씬 나은것같다 ㅎㅎ Main까지갑시다!

});
},
});
} catch (error) {
console.log('catch error', error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

콘솔로그는 없어도 될것같습니다..! console.error를 던져줘도 될것 같아요.

@soomin9106 soomin9106 merged commit f90f43c into develop Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants