-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Qa/workbook 111 ] workbook qa #112
Conversation
@@ -43,13 +45,18 @@ export const useSubscribeForm = () => { | |||
}); | |||
}, | |||
onError: (error) => { | |||
console.error(error); | |||
let errorMessage = '구독 신청이 되지 않았습니다.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요것도 상수로 관리할까요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
팝업 없애니까 훨씬 나은것같다 ㅎㅎ Main까지갑시다!
}); | ||
}, | ||
}); | ||
} catch (error) { | ||
console.log('catch error', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
콘솔로그는 없어도 될것같습니다..! console.error를 던져줘도 될것 같아요.
🔥 Related Issues
resolve #111
close #111
💜 작업 내용
✅ PR Point
😡 Trouble Shooting
👀 스크린샷 / GIF / 링크