Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop -> Main #159

Closed
wants to merge 9 commits into from
Closed

Develop -> Main #159

wants to merge 9 commits into from

Conversation

soomin9106
Copy link
Collaborator

🔥 Related Issues

Develop -> Main

Copy link

cloudflare-workers-and-pages bot commented Aug 17, 2024

Deploying 24th-web-team-1-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: f519714
Status: ✅  Deploy successful!
Preview URL: https://cf5fa4da.24th-web-team-1-fe.pages.dev
Branch Preview URL: https://develop.24th-web-team-1-fe.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Aug 17, 2024

Deploying 24th-web-team-1-fe-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: f519714
Status: ✅  Deploy successful!
Preview URL: https://ed641064.24th-web-team-1-fe-storybook.pages.dev
Branch Preview URL: https://develop.24th-web-team-1-fe-storybook.pages.dev

View logs

@Happhee
Copy link
Collaborator

Happhee commented Aug 17, 2024

믹스패널 주석해제 해주시고 가십셔..!

nextUrl.searchParams.delete(AUTH_TOKEN);
const response = NextResponse.redirect(nextUrl);

// response.cookies.set(COOKIES.ACCESS_TOKEN, "false");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 주석도 안쓰시면 삭제 부탁드립니다..!

const response = NextResponse.redirect(nextUrl);

response.cookies.set(COOKIES.ACCESS_TOKEN, authData?.data?.accessToken);
response.cookies.set(COOKIES.REFRESH_TOKEN, authData?.data?.refreshToken);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessToken 이걸로 저장해도 될것같네요..!

@soomin9106 soomin9106 closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants