-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop -> Main #159
Closed
Closed
Develop -> Main #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ Bugfix/dev 89 ] Develop
[ Fix/safari login ] safari 재접속시 로그인 쿠키 사라지는 현상 해결
Deploying 24th-web-team-1-fe with Cloudflare Pages
|
Deploying 24th-web-team-1-fe-storybook with Cloudflare Pages
|
믹스패널 주석해제 해주시고 가십셔..! |
Happhee
approved these changes
Aug 17, 2024
src/shared/middlewares/auth.ts
Outdated
nextUrl.searchParams.delete(AUTH_TOKEN); | ||
const response = NextResponse.redirect(nextUrl); | ||
|
||
// response.cookies.set(COOKIES.ACCESS_TOKEN, "false"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 주석도 안쓰시면 삭제 부탁드립니다..!
src/shared/middlewares/auth.ts
Outdated
const response = NextResponse.redirect(nextUrl); | ||
|
||
response.cookies.set(COOKIES.ACCESS_TOKEN, authData?.data?.accessToken); | ||
response.cookies.set(COOKIES.REFRESH_TOKEN, authData?.data?.refreshToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessToken 이걸로 저장해도 될것같네요..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
Develop -> Main