-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Feature/dev 97 ] 퀴즈에서 아티클로 다시 넘어가기 #165
Conversation
PR 포인트 (코드 설명) 및 스크린샷 추가 예정입니다!! |
테스트코드 추가해주세요!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠르게 작업하셨네요!! 수고하셨습니다~!!
}: ArticleDropDownWrapperProps) { | ||
return ( | ||
<> | ||
{toggleArticle && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
외부에서 제어하지 않고 articleDropdown wrapper에서 제어하신 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ArticleDropDownWrapper 하위에 있는 ArticleDropDown 은 toggle 에 영향을 받지 않도록 구성하고 싶어서 wrapper 로 하나 더 감쌌습니다!!
<div className="relative w-full max-w-[480px] bg-white"> | ||
<div className="absolute top-0 right-0 p-4"> | ||
<CancelButton handleToggle={handleToggleArticle} /> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 div를classname의 용도로만 사용하는 것이라면 cancelButton이 classname을 상속받을 수 있도록 props를 지정해주면 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영 했습니당
|
||
const backToArticleWords = problemAnswerInfo | ||
? BACK_TO_ARTICLE_WORDS.AFTER | ||
: BACK_TO_ARTICLE_WORDS.BEFORE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 조건문으로 분리하는 로직도 model로 만들면 어떨까요..? 컴포넌트에서는 오로지 뷰의 요소만 있었으면 좋겠습니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조건문 분리 로직을 모델로 분리했습니다!
@soomin9106 아네네!! 다 확인했는데 이상없네요!! 수고 많으셨어요! |
🔥 Related Issues
https://linear.app/fewletter/issue/DEV-97/%ED%80%B4%EC%A6%88%EC%97%90%EC%84%9C-%EC%95%84%ED%8B%B0%ED%81%B4%EB%A1%9C-%EB%8B%A4%EC%8B%9C-%EB%84%98%EC%96%B4%EA%B0%80%EA%B8%B0
💜 작업 내용
✅ PR Point
useProblemIdsViewModel
모델에getArticleId
추가 => 현재 문제에 해당하는 아티클 아이디 사용CancelButton
컴포넌트 추가하여 X 버튼 클릭 시 토글 처리 가능하도록 함👀 스크린샷 / GIF / 링크
퀴즈 풀기 전
퀴즈 푼 후
아티클 열었을 때