[ Feature/DEV-117 ] 스토리북 환경 개선 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop -> Main
[ bugfix/workbook-card ] style : workbook card height
Deploying 24th-web-team-1-fe-storybook with
|
| Latest commit: |
3c073c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://281ab658.24th-web-team-1-fe-storybook.pages.dev |
| Branch Preview URL: | https://feature-dev-117.24th-web-team-1-fe-storybook.pages.dev |
soomin9106
reviewed
Oct 9, 2024
There was a problem hiding this comment.
mdx 파일을 따로 놓은 이유가 있나용??
There was a problem hiding this comment.
@soomin9106 이건 혹시나 디자이너 분께 설명이 필요하거나, 아니면 우리끼리 컴포넌트 명세서 작성하는 파일로 생각하면 될것 같아요.
soomin9106
approved these changes
Oct 9, 2024
|
UI 에 케이스가 많을 때 저희도 유용하게 코드를 확인 할 수 있을 것 같아용!! 저도 조금 더 알아보겠습니다 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
https://linear.app/fewletter/issue/DEV-117/2차-관련-스토리북-개선
💜 작업 내용
✅ PR Point
폴더 구조 변경
원래 컴포넌트파일명/{컴포넌트명}.stories . 로 사용하기로 했는데, 해당 구조가 헷갈리는 것같아. story라는 폴더를 하나 만들었습니다!
이부분 피드백 부탁드립니다 !!
워크북 단일 카드 스토리 / 워크북 리스트 스토리 (모킹)
WorkbookCard.stories.tsx에서는 단일 스토리를 보여주었고,WorkbookCardList.stories.tsx에서는 모킹 기반으로 컴포넌트를 보여주었습니다!mdx 파일 작성
해당 부분은 디자이너 분께 보여드릴 문서로 이해해주시면 될 것 같습니다!
👀 스크린샷 / GIF / 링크
https://32522858.24th-web-team-1-fe-storybook.pages.dev/
📚 Reference