[ Feature/workbook 41 ] Skeleton 화면 구현 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying 24th-web-team-1-fe with
|
| Latest commit: |
bd4a8ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bcd2dea.24th-web-team-1-fe.pages.dev |
| Branch Preview URL: | https://feature-workbook-41.24th-web-team-1-fe.pages.dev |
Happhee
reviewed
Jun 14, 2024
| <Skeleton className="h-[30px] w-full" style={{ marginTop: "9px" }} /> | ||
| <Skeleton className="h-[30px] w-full" style={{ marginTop: "9px" }} /> | ||
| <Skeleton className="h-[30px] w-full" style={{ marginTop: "9px" }} /> | ||
| <Skeleton className="h-[30px] w-full" style={{ marginTop: "9px" }} /> |
There was a problem hiding this comment.
이거 contentSkelton으로 분리하고 map 돌리면 어떨까요
There was a problem hiding this comment.
좋아요 !! 다른 데에서도 쓰일 법하니 common 으로 빼둘게요!!
길이 & 스타일은 props 로 넣을 수 있도록 할게용 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
resolve #41
close #41
💜 작업 내용
✅ PR Point
`export const _1_SECOND = 1_000;
export const _3_SECOND = 3_000;
export const delay = (second = _3_SECOND) => new Promise((resolve) => setTimeout(resolve, second));`
👀 스크린샷 / GIF / 링크