[ Feature/article-56 ] 아티클 페이지 개발 및 이메일 템플릿 컴포넌트 구현 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soomin9106
reviewed
Jun 19, 2024
There was a problem hiding this comment.
이 부분을 common 으로 뺐네용!! 좋습니당 👍
soomin9106
reviewed
Jun 19, 2024
| export type ProblemListContextInfo = { | ||
| states: { | ||
| problemList: number[]; | ||
| problemList: ProblemListInfo[]; |
There was a problem hiding this comment.
이거는 number[] 가 바뀔 수도 있다는 가정 하에 타입명을 지정해준건가용??
There was a problem hiding this comment.
@soomin9106 공통으로 관리하면 편할것같아서 지정했습니다.
soomin9106
reviewed
Jun 19, 2024
| case "1": | ||
| return HttpResponse.json(response[apiRoutes.article + "1"]); | ||
| } | ||
| return HttpResponse.json(response[apiRoutes.article + "1"]); |
There was a problem hiding this comment.
아아 파일 이름이 article1 이군요 ㅋㅋㅋㅋ
There was a problem hiding this comment.
@soomin9106 아뇨! 이거 id별로 데이터달라서 설정한거에요! response 파일보시면 압니다!
Happhee
changed the title
soomin9106
approved these changes
Jun 19, 2024
|
오오 완전 고생하셨습니다 👍 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
resolved #56
close #56
💜 작업 내용
✅ PR Point
svg -> current
📂 TitleSection
📂 EmailTemplate
😡 Trouble Shooting
👀 스크린샷 / GIF / 링크