-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Feature/article-56 ] 아티클 페이지 개발 및 이메일 템플릿 컴포넌트 구현 #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분을 common 으로 뺐네용!! 좋습니당 👍
export type ProblemListContextInfo = { | ||
states: { | ||
problemList: number[]; | ||
problemList: ProblemListInfo[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거는 number[] 가 바뀔 수도 있다는 가정 하에 타입명을 지정해준건가용??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soomin9106 공통으로 관리하면 편할것같아서 지정했습니다.
case "1": | ||
return HttpResponse.json(response[apiRoutes.article + "1"]); | ||
} | ||
return HttpResponse.json(response[apiRoutes.article + "1"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ "1"
은 /1
인가요...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아 파일 이름이 article1 이군요 ㅋㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soomin9106 아뇨! 이거 id별로 데이터달라서 설정한거에요! response 파일보시면 압니다!
오오 완전 고생하셨습니다 👍 💯 |
🔥 Related Issues
resolved #56
close #56
💜 작업 내용
✅ PR Point
svg -> current
📂 TitleSection
📂 EmailTemplate
😡 Trouble Shooting
👀 스크린샷 / GIF / 링크