[ Init/4 ] 스토리북 초기 환경 구축 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happhee
reviewed
Jun 2, 2024
.github/workflows/pull-request.yml
Outdated
| @@ -36,8 +36,6 @@ jobs: | |||
| if: steps.cache.outputs.cache-hit != 'true' | |||
| run: pnpm install | |||
| - name: Build storybook | |||
| run: | | |||
| pnpm run build-storybook | |||
| mv ./storybook-static ./build/storybook | |||
There was a problem hiding this comment.
mv 명령어가 안먹히는 이유가 있었나요?!! (궁금)
There was a problem hiding this comment.
아 저 폴더가 없어서용 !! 저 부분은 스토리북을 클라우드 서비스에 배포할 때 쓰는 것 같습니당
참고: https://storybook.js.org/docs/sharing/publish-storybook
tailwind.config.ts
Outdated
| @@ -7,6 +7,7 @@ const config = { | |||
| './components/**/*.{ts,tsx}', | |||
| './app/**/*.{ts,tsx}', | |||
| './src/**/*.{ts,tsx}', | |||
| './stories/**/*.{js,ts,jsx,tsx}', | |||
There was a problem hiding this comment.
아주 멋쟁이!! 꼼꼼한 config작성 감사합니다!
| [ | ||
| "^[./]", | ||
| ".*" | ||
| ] |
There was a problem hiding this comment.
이거 왜 우리 저장되는 형식이 다를까..? prettier가 다른가요..?!
There was a problem hiding this comment.
prettier 안돌렸나보네용 ㅠㅠ 돌리고 확인해볼게요!!
There was a problem hiding this comment.
@soomin9106 lint에러 발생했네요! 프리티어랑 같이 봐주세요!
There was a problem hiding this comment.
" 때문에 에러 났네용 ㅠㅠ 확인해서 커밋하구 머지 할게용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
resolve #5
💜 작업 내용
✅ PR Point
😡 Trouble Shooting
ESLint 설정 파일(.eslintrc.json)에 정의된 'eslint-plugin-unused-imports' 플러그인을 찾을 수 없어 lint 에러가 발생하여
pnpm add -D eslint-plugin-unused-imports을 통해서 패키지 설치 해주었습니다!
👀 스크린샷 / GIF / 링크
📚 Reference