-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Init/4 ] 스토리북 초기 환경 구축 #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많았어 수민!! src하위 경로로 이동시키고 merge하면 될것같아!!!
.github/workflows/pull-request.yml
Outdated
@@ -36,8 +36,6 @@ jobs: | |||
if: steps.cache.outputs.cache-hit != 'true' | |||
run: pnpm install | |||
- name: Build storybook | |||
run: | | |||
pnpm run build-storybook | |||
mv ./storybook-static ./build/storybook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mv 명령어가 안먹히는 이유가 있었나요?!! (궁금)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 저 폴더가 없어서용 !! 저 부분은 스토리북을 클라우드 서비스에 배포할 때 쓰는 것 같습니당
참고: https://storybook.js.org/docs/sharing/publish-storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soomin9106 아하! 확인했습니다!
tailwind.config.ts
Outdated
@@ -7,6 +7,7 @@ const config = { | |||
'./components/**/*.{ts,tsx}', | |||
'./app/**/*.{ts,tsx}', | |||
'./src/**/*.{ts,tsx}', | |||
'./stories/**/*.{js,ts,jsx,tsx}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 멋쟁이!! 꼼꼼한 config작성 감사합니다!
[ | ||
"^[./]", | ||
".*" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 왜 우리 저장되는 형식이 다를까..? prettier가 다른가요..?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier 안돌렸나보네용 ㅠㅠ 돌리고 확인해볼게요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soomin9106 lint에러 발생했네요! 프리티어랑 같이 봐주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"
때문에 에러 났네용 ㅠㅠ 확인해서 커밋하구 머지 할게용
🔥 Related Issues
resolve #5
💜 작업 내용
✅ PR Point
😡 Trouble Shooting
ESLint 설정 파일(.eslintrc.json)에 정의된 'eslint-plugin-unused-imports' 플러그인을 찾을 수 없어 lint 에러가 발생하여
pnpm add -D eslint-plugin-unused-imports
을 통해서 패키지 설치 해주었습니다!
👀 스크린샷 / GIF / 링크
📚 Reference