Merge pull request #164 from YAPP-Github/QA/backlog-qa

Qa/backlog 백로그 QA 일부 반영
YAPP-Github · Apr 1, 2024 · f9a4acb · f9a4acb
2 parents 83ec21d + 6a794ac
commit f9a4acb
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 18 deletions.
diff --git a/...signsystem/src/main/java/com/susu/core/designsystem/component/dialog/SusuCheckedDialog.kt b/...signsystem/src/main/java/com/susu/core/designsystem/component/dialog/SusuCheckedDialog.kt
@@ -105,7 +105,7 @@ fun SusuCheckedDialog(
                         text = it,
                         onClick = onDismissRequest,
                     )
-                    Spacer(modifier = Modifier.height(SusuTheme.spacing.spacing_xxs))
+                    Spacer(modifier = Modifier.width(SusuTheme.spacing.spacing_xxs))
                 }
                 SusuFilledButton(
                     modifier = Modifier.weight(1f),

diff --git a/core/designsystem/src/main/java/com/susu/core/designsystem/component/dialog/SusuDialog.kt b/core/designsystem/src/main/java/com/susu/core/designsystem/component/dialog/SusuDialog.kt
@@ -7,6 +7,7 @@ import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.width
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
@@ -74,7 +75,7 @@ fun SusuDialog(
                         text = it,
                         onClick = onDismissRequest,
                     )
-                    Spacer(modifier = Modifier.height(SusuTheme.spacing.spacing_xxs))
+                    Spacer(modifier = Modifier.width(SusuTheme.spacing.spacing_xxs))
                 }
                 SusuFilledButton(
                     modifier = Modifier.weight(1f),

diff --git a/...esignsystem/src/main/java/com/susu/core/designsystem/component/textfield/SusuTextField.kt b/...esignsystem/src/main/java/com/susu/core/designsystem/component/textfield/SusuTextField.kt
@@ -86,7 +86,7 @@ fun SusuPriceTextField(
     val moneyUnitString = stringResource(R.string.money_unit)
     SusuBasicTextField(
         modifier = modifier,
-        text = text,
+        text = text.toLongOrNull()?.toString() ?: "",
         onTextChange = onTextChange,
         placeholder = placeholder,
         textColor = textColor,

diff --git a/data/src/main/java/com/susu/data/data/repository/ExcelRepositoryImpl.kt b/data/src/main/java/com/susu/data/data/repository/ExcelRepositoryImpl.kt
@@ -19,7 +19,7 @@ class ExcelRepositoryImpl @Inject constructor(
         val request = DownloadManager.Request(url.toUri())
             .setMimeType(mimeType)
             .setAllowedOverMetered(true)
-            .setNotificationVisibility(DownloadManager.Request.VISIBILITY_VISIBLE)
+            .setNotificationVisibility(DownloadManager.Request.VISIBILITY_VISIBLE_NOTIFY_COMPLETED)
             .setTitle(downloaderName)
             .addRequestHeader(headerTokenName, token)
             .setDestinationInExternalPublicDir(Environment.DIRECTORY_DOWNLOADS, fileName)

diff --git a/feature/mypage/src/main/java/com/susu/feature/mypage/main/MyPageDefaultScreen.kt b/feature/mypage/src/main/java/com/susu/feature/mypage/main/MyPageDefaultScreen.kt
@@ -198,7 +198,10 @@ fun MyPageDefaultScreen(
             titleTextStyle = SusuTheme.typography.title_m,
             action = {
                 Row(
-                    modifier = Modifier.susuClickable(onClick = navigateToInfo),
+                    modifier = Modifier.susuClickable(
+                        rippleEnabled = false,
+                        onClick = navigateToInfo,
+                    ),
                 ) {
                     Text(
                         text = stringResource(com.susu.feature.mypage.R.string.mypage_default_my_info),

diff --git a/...in/java/com/susu/feature/received/ledgerdetail/component/LedgerDetailEnvelopeContainer.kt b/...in/java/com/susu/feature/received/ledgerdetail/component/LedgerDetailEnvelopeContainer.kt
@@ -148,8 +148,8 @@ fun LedgerDetailEnvelopeContainerPreview() {
                     relation = "관계관계관계",
                     customRelation = null,
                     description = null,
-                )
-            )
+                ),
+            ),
         ) {
         }
     }

diff --git a/feature/sent/src/main/java/com/susu/feature/envelopefilter/EnvelopeFilterScreen.kt b/feature/sent/src/main/java/com/susu/feature/envelopefilter/EnvelopeFilterScreen.kt
@@ -20,7 +20,6 @@ import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.runtime.snapshotFlow
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
@@ -152,7 +151,7 @@ fun EnvelopeFilterScreen(
     Column(
         modifier = Modifier
             .background(SusuTheme.colorScheme.background10)
-            .fillMaxSize()
+            .fillMaxSize(),
     ) {
         SusuDefaultAppBar(
             leftIcon = {

diff --git a/feature/statistics/src/main/java/com/susu/feature/statistics/component/StatisticsTab.kt b/feature/statistics/src/main/java/com/susu/feature/statistics/component/StatisticsTab.kt
@@ -12,6 +12,7 @@ import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.draw.clip
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import com.susu.core.designsystem.theme.Gray10
@@ -57,14 +58,15 @@ fun StatisticsTabItem(
     onClick: () -> Unit,
 ) {
     Box(
-        modifier = modifier.fillMaxSize().background(
-            color = if (isSelected) {
-                Gray20
-            } else {
-                Gray10
-            },
-            shape = RoundedCornerShape(4.dp),
-        ).susuClickable(onClick = onClick),
+        modifier = modifier.fillMaxSize()
+            .clip(RoundedCornerShape(4.dp))
+            .background(
+                color = if (isSelected) {
+                    Gray20
+                } else {
+                    Gray10
+                },
+            ).susuClickable(onClick = onClick),
     ) {
         Text(
             modifier = Modifier.align(Alignment.Center),

diff --git a/...istics/src/main/java/com/susu/feature/statistics/content/susu/SusuStatisticsOptionSlot.kt b/...istics/src/main/java/com/susu/feature/statistics/content/susu/SusuStatisticsOptionSlot.kt
@@ -14,6 +14,7 @@ import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.draw.clip
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
@@ -115,7 +116,9 @@ fun OptionSlot(
     onClick: () -> Unit = {},
 ) {
     Row(
-        modifier = modifier.background(color = Gray10, shape = RoundedCornerShape(4.dp))
+        modifier = modifier
+            .clip(RoundedCornerShape(4.dp))
+            .background(color = Gray10)
             .susuClickable(onClick = onClick)
             .padding(
                 horizontal = SusuTheme.spacing.spacing_xxs,