Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mz 154 navigation setting #18

Merged
merged 10 commits into from
Dec 26, 2023
Merged

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 23, 2023

💡 Issue

🌱 Key changes

  • Navigation 관련 작업했습니다.

✅ To Reviewers

  • @syb8200 님이 만드셨던 NavigationBar 조금 수정했습니다. 확인 부탁드려요.
  • Compose Alpha 버전으로 변경했습니다. (WindowInset이 잘 안먹는 이슈가 있었어요.)
  • pure java/kotlin 모듈의 모델은 컴포즈에서 unstable하다고 판단하기 때문에 이를 해결하기 위해 compose-stable-marker 라이브러리 추가했습니다.
  • list, set, map은 컴포즈에서 unstable하다고 판단하기 때문에 kotlinx-immutable-collection 라이브러리를 추가했습니다.
  • Compose Compiler Reports를 이용해 stable, unstable 여부를 report 결과로 받아볼 수 있습니다. 링크의 Compose Compiler Reports 부분을 참고해주세요.

📸 스크린샷

스크린샷
화면 기록 2023-12-23 오후 5 29 46

@jinukeu jinukeu self-assigned this Dec 23, 2023
Copy link
Member

@yangsooplus yangsooplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

링크해주신 포스트도 잘 읽어보았습니다 ~!

Copy link
Contributor

@syb8200 syb8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@jinukeu jinukeu merged commit 083a1e8 into develop Dec 26, 2023
1 check passed
@jinukeu jinukeu deleted the feature/MZ-154-navigation-setting branch January 15, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Navigation Setting
3 participants