Feature/mz 160 splash, signup-vote, login UI #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 이하는 따로 대응해야 함
yangsooplus
commented
Jan 6, 2024
Comment on lines
+42
to
+47
| val buttonList = listOf( | ||
| stringResource(R.string.signup_vote_unit_3), | ||
| stringResource(R.string.signup_vote_unit_5), | ||
| stringResource(R.string.signup_vote_unit_10), | ||
| stringResource(R.string.signup_vote_unit_20), | ||
| ) |
There was a problem hiding this comment.
요렇게 이 화면에서만 사용하는 상수 어떻게 관리하면 좋을까요?
There was a problem hiding this comment.
음 private const val로 빼고 Resid 값을 저장하면 좋을거같아요.
jinukeu
requested changes
Jan 6, 2024
Comment on lines
+42
to
+47
| val buttonList = listOf( | ||
| stringResource(R.string.signup_vote_unit_3), | ||
| stringResource(R.string.signup_vote_unit_5), | ||
| stringResource(R.string.signup_vote_unit_10), | ||
| stringResource(R.string.signup_vote_unit_20), | ||
| ) |
There was a problem hiding this comment.
음 private const val로 빼고 Resid 값을 저장하면 좋을거같아요.
Comment on lines
31
to
42
| LaunchedEffect(key1 = fillAngle) { | ||
| launch { | ||
| fillAngle.animateTo( | ||
| targetValue = fillUntil, | ||
| animationSpec = tween( | ||
| delayMillis = delay, | ||
| durationMillis = duration, | ||
| easing = EaseInOutCubic, | ||
| ), | ||
| ) | ||
| } | ||
| } |
| viewModel: LoginViewModel = hiltViewModel(), | ||
| navigateToReceived: () -> Unit, | ||
| navigateToSignUp: () -> Unit, | ||
| ) { | ||
| val context = LocalContext.current | ||
| // TODO: Loading 처리 | ||
| val uiState by viewModel.uiState.collectAsState() |
Comment on lines
133
to
136
| CircularProgressIndicator( | ||
| modifier = Modifier.align(Alignment.Center), | ||
| color = SusuTheme.colorScheme.primary | ||
| ) |
There was a problem hiding this comment.
요거 designsystem에 LoadingScreen으로 만들어주실 수 있나요?
| Button( | ||
| onClick = onClick, | ||
| modifier = Modifier.wrapContentHeight(), | ||
| fun KakaoLogin( |
Comment on lines
174
to
178
| .susuClickable( | ||
| rippleEnabled = false, | ||
| ) { | ||
| onClick() | ||
| } |
There was a problem hiding this comment.
ripple 넣어주시구, susuClickable(rippleEnabled = false, onClick = onClick) 이 더 이쁠거같아요
jinukeu
reviewed
Jan 6, 2024
| fun KakaoLogin( | ||
| onClick: () -> Unit, | ||
| ) { | ||
| Box( |
There was a problem hiding this comment.
syb8200
reviewed
Jan 6, 2024
| append(stringResource(R.string.signup_vote_question_5)) | ||
| } | ||
| }, | ||
| lineHeight = 40.sp, |
There was a problem hiding this comment.
이렇게 따로 lineHeight를 지정한 이유가 뭘까욥..??
There was a problem hiding this comment.
요 부분인데, AnnotatedString을 쓰면서 2가지 textStyle(title_l, text_l)을 이미 spanStyle로 지정한 상태거든요
그 textStyle 안에 lineHeight가 정의되어 있는데, 아래처럼 안 먹어서 따로 지정해주었습니다~
jinukeu
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
✅ To Reviewers
📸 스크린샷
KakaoTalk_Video_2024-01-06-15-37-05.mp4