-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mz 160 splash, signup-vote, login UI #41
Conversation
30 이하는 따로 대응해야 함
val buttonList = listOf( | ||
stringResource(R.string.signup_vote_unit_3), | ||
stringResource(R.string.signup_vote_unit_5), | ||
stringResource(R.string.signup_vote_unit_10), | ||
stringResource(R.string.signup_vote_unit_20), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요렇게 이 화면에서만 사용하는 상수 어떻게 관리하면 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 private const val로 빼고 Resid 값을 저장하면 좋을거같아요.
val buttonList = listOf( | ||
stringResource(R.string.signup_vote_unit_3), | ||
stringResource(R.string.signup_vote_unit_5), | ||
stringResource(R.string.signup_vote_unit_10), | ||
stringResource(R.string.signup_vote_unit_20), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 private const val로 빼고 Resid 값을 저장하면 좋을거같아요.
LaunchedEffect(key1 = fillAngle) { | ||
launch { | ||
fillAngle.animateTo( | ||
targetValue = fillUntil, | ||
animationSpec = tween( | ||
delayMillis = delay, | ||
durationMillis = duration, | ||
easing = EaseInOutCubic, | ||
), | ||
) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
launch를 쓴 이유가 뭔가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 긁어오다가 딸려 들어온 것 같슴다
viewModel: LoginViewModel = hiltViewModel(), | ||
navigateToReceived: () -> Unit, | ||
navigateToSignUp: () -> Unit, | ||
) { | ||
val context = LocalContext.current | ||
// TODO: Loading 처리 | ||
val uiState by viewModel.uiState.collectAsState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectAsStateWithLifecycle()
CircularProgressIndicator( | ||
modifier = Modifier.align(Alignment.Center), | ||
color = SusuTheme.colorScheme.primary | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 designsystem에 LoadingScreen으로 만들어주실 수 있나요?
Button( | ||
onClick = onClick, | ||
modifier = Modifier.wrapContentHeight(), | ||
fun KakaoLogin( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 Button 이죠? 네이밍 변경 부탁드릴게요!
.susuClickable( | ||
rippleEnabled = false, | ||
) { | ||
onClick() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ripple 넣어주시구, susuClickable(rippleEnabled = false, onClick = onClick) 이 더 이쁠거같아요
fun KakaoLogin( | ||
onClick: () -> Unit, | ||
) { | ||
Box( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Box 없어도 되지 않나유?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
append(stringResource(R.string.signup_vote_question_5)) | ||
} | ||
}, | ||
lineHeight = 40.sp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 따로 lineHeight를 지정한 이유가 뭘까욥..??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 수고하셨습니다!
💡 Issue
🌱 Key changes
✅ To Reviewers
📸 스크린샷
KakaoTalk_Video_2024-01-06-15-37-05.mp4