Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor init route and create snackbar #44

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jan 7, 2024

πŸ’‘ Issue

🌱 Key changes

  • μŠ€λ‚΅λ°” κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
  • 초기 Route μ§€μ •ν•΄μ£ΌλŠ” λΆ€λΆ„ λ¦¬νŒ©ν† λ§ ν–ˆμŠ΅λ‹ˆλ‹€.

βœ… To Reviewers

@yangsooplus μˆ˜μ§„λ‹˜ μ½”λ“œ 쑰금 많이 κ±΄λ“œλ ΈμŠ΅λ‹ˆλ‹€! ν•œλ²ˆ 확인 λΆ€νƒλ“œλ¦΄κ²Œμš”!

μŠ€λ‚΅λ°” μ‚¬μš© μ˜ˆμ‹œμž…λ‹ˆλ‹€.
mutex μ‚¬μš©ν•΄μ„œ snackbarκ°€ κ²ΉμΉ˜μ§€ μ•Šκ²Œ λ°©μ–΄ν–ˆμŠ΅λ‹ˆλ‹€.

fun NavGraphBuilder.sentNavGraph(
    padding: PaddingValues,
    onShowToast: (SnackbarToken) -> Unit,
) {
    composable(route = SentRoute.route) {
        SentScreen(
            padding = padding,
            onShowToast = onShowToast,
        )
    }
}
// MainScreen
sentNavGraph(
    padding = innerPadding,
    onShowToast = viewModel::onShowToast,
)
@Composable
fun SentScreen(
    padding: PaddingValues,
    modifier: Modifier = Modifier,
    clickPadding: Dp = SusuTheme.spacing.spacing_xs,
    onShowToast: (SnackbarToken) -> Unit = {},
) {
    // TODO Example λ§ˆμŒλŒ€λ‘œ 제거 κ°€λŠ₯
    LaunchedEffect(key1 = Unit) {
        repeat(3) {
            onShowToast(SnackbarToken(message = "ν…ŒμŠ€νŠΈ $it"))
        }
    }

πŸ“Έ μŠ€ν¬λ¦°μƒ·

μŠ€ν¬λ¦°μƒ·1 μŠ€ν¬λ¦°μƒ·2
스ᄂᅒᆨᄇᅑ image

@jinukeu jinukeu added the feature label Jan 7, 2024
@jinukeu jinukeu self-assigned this Jan 7, 2024
# Conflicts:
#	feature/navigator/src/main/java/com/susu/feature/navigator/MainNavigator.kt
Copy link
Member

@yangsooplus yangsooplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμ–΄μš”~ MainViewModel이 MainScreen μ•ˆμ— λ“€μ–΄κ°€λ‹ˆ μ½”λ“œκ°€ 보기 μ’‹λ„€μš”
PR 제λͺ©μ— 초기 Route λ¦¬νŒ©ν† λ§ κ΄€λ ¨ν•œ λ‚΄μš©λ„ 적어주면 쒋을 것 κ°™μ•„μš”!

kakaoAccessToken = kakaoAccessToken,
)
}
delay(NAVIGATE_DELAY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš” λ”œλ ˆμ΄λŠ” 무슨 이유둜 λ“€μ–΄κ°„ κ±΄κ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ”œλ ˆμ΄λ₯Ό μ•ˆμ£Όλ©΄ ν™”λ©΄ μ΄λ™λ˜λŠ” μ• λ‹ˆλ©”μ΄μ…˜μ΄ λ…ΈμΆœλ˜λ”λΌκ΅¬μš©!! κ·Έλž˜μ„œ λ„£μ—ˆμŠ΄λ‹€

@jinukeu jinukeu changed the title Feature/snackbar Feature/refactor init route and create snackbar Jan 9, 2024
@yangsooplus
Copy link
Member

πŸ‘

@jinukeu jinukeu merged commit f629ede into develop Jan 9, 2024
1 check passed
@jinukeu jinukeu deleted the feature/snackbar branch January 15, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] SnackBar κ΅¬ν˜„
2 participants