Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mz 178 sent envelopes detail edit #60

Merged
merged 11 commits into from
Jan 14, 2024
Merged

Feature/mz 178 sent envelopes detail edit #60

merged 11 commits into from
Jan 14, 2024

Conversation

syb8200
Copy link
Contributor

@syb8200 syb8200 commented Jan 14, 2024

๐Ÿ’ก Issue

๐ŸŒฑ Key changes

๋ณด๋‚ด์š” ๋ด‰ํˆฌ ์ƒ์„ธ ํŽธ์ง‘ UI ์ž‘์—… ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ… To Reviewers

  • UI ์ž‘์—… ์œ„์ฃผ๋กœ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • imePadding()์„ ์ ์šฉํ–ˆ๋Š”๋ฐ, ํ‚ค๋ณด๋“œ์— ๊ฐ€๋ ค์„œ ๋ฉ”๋ชจ ๋ถ€๋ถ„ TextField๋ฅผ ๋ˆ„๋ฅด๋ฉด ํ™”๋ฉด์ด ์•ˆ๋ณด์ด๋Š” ์ด์Šˆ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค..
    ์ตœ์ข… ์‹œ์•ˆ ์ƒ์—์„œ๋„ ์–ด๋Š ์ •๋„ ๋ฉ”๋ชจ ํ•˜๋‹จ ๋ถ€๋ถ„์— ์–ด๋Š ์ •๋„ ์—ฌ๋ฐฑ์ด ์žˆ๊ธด ํ•œ๋ฐ, ๋‹จ์ˆœํžˆ ํ•ด๋‹น ์—ฌ๋ฐฑ์„ dp๋กœ ๋Š˜๋ฆฌ๋Š” ๊ฑด ์ข‹์ง€ ์•Š์€ ๋ฐฉ๋ฒ•์ธ ๊ฒƒ ๊ฐ™์•„์„œ..
    ํ˜น์‹œ ์ด ๋ถ€๋ถ„์— ๋Œ€ํ•ด์„œ ํ•ด๊ฒฐ ๋ฐฉ๋ฒ•์„ ์•„์‹œ๋Š” ๋ถ„์ด ๊ณ„์‹ค๊นŒ์šฅ...ใ… 

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

image
SentEnvelopeEdit

@syb8200 syb8200 self-assigned this Jan 14, 2024
@jinukeu
Copy link
Member

jinukeu commented Jan 14, 2024

ํ™”๋ฉด ์•ˆ๋ณด์ด๋Š” ์ด์Šˆ ์ œ๊ฐ€ ํ•ด๊ฒฐํ•ด์„œ ์ปค๋ฐ‹ํ–ˆ์–ด์š”~!
์ฝ”๋ฉ˜ํŠธ๋กœ ๋‚จ๊ธฐ๊ธฐ์—๋Š” ๋ฒˆ๊ฑฐ๋กœ์›Œ์„œ ์ง์ ‘ ์ปค๋ฐ‹ ํ›„ ํ‘ธ์‹œํ–ˆ์Šต๋‹ˆ๋‹ค. ์–‘ํ•ด ๋ถ€ํƒ๋“œ๋ ค์š” :)

jinukeu
jinukeu requested changes Jan 14, 2024
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~ ๋ช‡๊ฐ€์ง€ ์ฝ”๋ฉ˜ํŠธ๋งŒ ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š”!

feature/sent/src/main/java/com/susu/feature/envelopeedit/SentEnvelopeEditScreen.kt Outdated
top = SusuTheme.spacing.spacing_xl,
),
) {
SusuBasicTextField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SusuPriceTextField ์ˆ˜์ง„๋‹˜์ด ๋งŒ๋“ค์–ด๋†“์€๊ฑฐ ์จ์ฃผ์„ธ์œ ~

feature/sent/src/main/java/com/susu/feature/envelopeedit/component/EditDetailItem.kt

@OptIn(ExperimentalLayoutApi::class)
@Composable
fun EditDetailItem(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview ์ถ”๊ฐ€๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”~!

@syb8200
Copy link
Contributor Author

syb8200 commented Jan 14, 2024

ํ™”๋ฉด ์•ˆ๋ณด์ด๋Š” ์ด์Šˆ ์ œ๊ฐ€ ํ•ด๊ฒฐํ•ด์„œ ์ปค๋ฐ‹ํ–ˆ์–ด์š”~! ์ฝ”๋ฉ˜ํŠธ๋กœ ๋‚จ๊ธฐ๊ธฐ์—๋Š” ๋ฒˆ๊ฑฐ๋กœ์›Œ์„œ ์ง์ ‘ ์ปค๋ฐ‹ ํ›„ ํ‘ธ์‹œํ–ˆ์Šต๋‹ˆ๋‹ค. ์–‘ํ•ด ๋ถ€ํƒ๋“œ๋ ค์š” :)

๋‚˜๋ฆ„ ์ด๋ฆฌ์ €๋ฆฌ ํ•ด๋ดค์—ˆ๋Š”๋ฐ ์ € ์ƒ๊ฐ์€ ๋ชปํ–ˆ๋˜ ๊ฒƒ ๊ฐ™์•„์š”.. ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹คใ… 

@syb8200 syb8200 requested a review from jinukeu January 14, 2024 15:04
jinukeu
jinukeu approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@syb8200 syb8200 merged commit 126fd01 into develop Jan 14, 2024
1 check passed
@jinukeu jinukeu deleted the feature/MZ-178-sent-envelopes-detail-edit branch January 15, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinukeu jinukeu jinukeu approved these changes

@yangsooplus yangsooplus Awaiting requested review from yangsooplus

Assignees

@syb8200 syb8200

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ๋ณด๋‚ด์š” ๋ด‰ํˆฌ ์ƒ์„ธ ํŽธ์ง‘ UI ์ž‘์—…
2 participants
@syb8200 @jinukeu