Feature/datepicker-limit SusuLimitDatePickerBottomSheet 컴포넌트 추가 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
reviewed
Jan 15, 2024
Comment on lines
+117
to
+119
| criteriaYear: Int, | ||
| criteriaMonth: Int, | ||
| criteriaDay: Int, |
There was a problem hiding this comment.
혹시 initialYear, Month, Day 도 추가가능할까요 선생님 ... ?
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋ 시작 날짜랑 기준 날짜랑 다른 경우도 있겠군요 잠시만여
There was a problem hiding this comment.
feat: SusuLimitDatePickerBottomSheet에 initialXXX 추가
추가했어요! 대신 initialXXX가 기준 날짜 범위 외가 되지 않도록 사용해야 할 것 같슴다
터지지는 않고 기준 날짜로 바꾸도록 처리해뒀긴 했슴니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 Key changes
1930.01.01 ~ 기준 날짜혹은기준 날짜 ~ 2030.12.31범위만 선택할 수 있는SusuLimitDatePickerBottomSheetafterDate가 true 면 이후 범위, false면 이전 범위 입니다📸 스크린샷
각각 이전, 이후 날짜 선택하는 예시입니다.