Feature/mz 181 ledger filter #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/ui/src/main/res/values/strings.xml # feature/navigator/src/main/java/com/susu/feature/navigator/MainNavigator.kt # feature/navigator/src/main/java/com/susu/feature/navigator/MainScreen.kt # feature/received/src/main/java/com/susu/feature/received/navigation/ReceivedNavigation.kt # feature/received/src/main/java/com/susu/feature/received/received/ReceivedScreen.kt # feature/received/src/main/res/values/strings.xml
yangsooplus
approved these changes
Jan 23, 2024
Comment on lines
+27
to
+47
| enum class LedgerAlign( | ||
| @StringRes val stringResId: Int, | ||
| val query: String, | ||
| ) { | ||
| RECENT( | ||
| stringResId = R.string.word_align_recently, | ||
| query = "createdAt,desc", | ||
| ), | ||
| OUTDATED( | ||
| stringResId = R.string.word_align_outdated, | ||
| query = "createdAt,asc", | ||
| ), | ||
| HIGH_AMOUNT( | ||
| stringResId = R.string.word_align_high_amount, | ||
| query = "totalReceivedAmounts,desc", | ||
| ), | ||
| LOW_AMOUNT( | ||
| stringResId = R.string.word_align_low_amount, | ||
| query = "totalReceivedAmounts,asc", | ||
| ), | ||
| } |
There was a problem hiding this comment.
이거 받아요도 같은 정렬 기준을 사용하던데 ui 모듈로 옮기는건 어떤가요??
There was a problem hiding this comment.
query값이 조금 달라서 분리했어요!
받아요에서는 totalReceivedAmounts 이구 보내요에서는 totalSentAmounts 이에요!
| val uiState = viewModel.uiState.collectAsStateWithLifecycle().value | ||
| viewModel.sideEffect.collectWithLifecycle { sideEffect -> | ||
| when (sideEffect) { | ||
| is LedgerFilterSideEffect.HandleException -> TODO() |
| } | ||
|
|
||
| fun getLedgerList(needClear: Boolean = false) = viewModelScope.launch { | ||
| mutex.withLock { |
There was a problem hiding this comment.
이 작업에 mutex가 필요한 이유가 무엇인가요?
There was a problem hiding this comment.
OnBottomReached이랑 Filter 과정 등 에서 getLedgerList 함수가 거의 동시에 실행되면서 race condition이 발생하더라구요 ㅜㅜ
There was a problem hiding this comment.
아아 왜지 싶었는데 OnBottomReached 때에 호출되어서 그랬군요 그렇다면 좀 더 늦게 호출된 getLedgerList는 버려지나요? 혹은 먼저 실행된 getLedgerList를 기다렸다가 실행되는건가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
✅ To Reviewers
📸 스크린샷
KakaoTalk_Video_2024-01-22-15-18-01.mp4