Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mz 134 vote add #89

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Feature/mz 134 vote add #89

merged 6 commits into from
Jan 24, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jan 24, 2024

๐Ÿ’ก Issue

๐ŸŒฑ Key changes

  • ํˆฌํ‘œ ์ž‘์„ฑ ๊ธฐ๋Šฅ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ… To Reviewers

SusuTextFieldButton์˜ ClearIcon์ด ์ œ๋Œ€๋กœ ๋ณด์ด์ง€ ์•Š๋Š” ํ˜„์ƒ์ด ์žˆ๋Š”๋ฐ, ๋””์ž์ด๋„ˆ๋ถ„๊ป˜์„œ vector ํŒŒ์ผ ์ˆ˜์ •ํ•ด์ฃผ์‹œ๋ฉด ๋ฐ˜์˜ํ•˜๊ณ  Merge ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

KakaoTalk_Video_2024-01-24-21-27-58.mp4

@jinukeu jinukeu self-assigned this Jan 24, 2024
Copy link
Member

@yangsooplus yangsooplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SusuTextFieldButton placeholder๊ฐ€ ๋ณด์ผ๋•Œ ์ปค์„œ๊ฐ€ ์ค‘์•™์— ์œ„์น˜ํ•˜๊ฒŒ ๋˜๋Š”๊ฒŒ ์‹ ๊ฒฝ์“ฐ์ด๋Š”๋ฐ... ์–ด๋–ป๊ฒŒ ์•ˆ๋ ๊นŒ์š”? ๐Ÿ‘€

@jinukeu
Copy link
Member Author

jinukeu commented Jan 24, 2024

SusuTextFieldButton placeholder๊ฐ€ ๋ณด์ผ๋•Œ ์ปค์„œ๊ฐ€ ์ค‘์•™์— ์œ„์น˜ํ•˜๊ฒŒ ๋˜๋Š”๊ฒŒ ์‹ ๊ฒฝ์“ฐ์ด๋Š”๋ฐ... ์–ด๋–ป๊ฒŒ ์•ˆ๋ ๊นŒ์š”? ๐Ÿ‘€

์Œ ํž˜๋“ค๊ฑฐ๊ฐ™์•„์š”
์ƒ๊ฐ์ฒ˜๋Ÿผ ์ž˜ ์•ˆ๋˜๋„ค์š” ...

@yangsooplus
Copy link
Member

ใ… ใ…  ๊ทธ๋ ‡๋‹ค๋ฉด ๋น„์–ด์žˆ๋Š” TextField๊ฐ€ ํฌ์ปค์Šค๋ฅผ ์–ป์—ˆ์„ ๋•Œ placeholder๋ฅผ ์ œ๊ฑฐํ•˜๊ณ  ๋นˆ์นธ์— ์ปค์„œ๋งŒ ๊นœ๋นก์ด๋Š” ์ƒํƒœ๋กœ ์ฒ˜๋ฆฌํ•˜๋ฉด ์–ด๋–จ๊นŒ์š”? ์ข€ ๋งŽ์ด ๊ฑฐ์Šฌ๋ฆฌ๋Š” ๊ฒƒ ๊ฐ™์•„์„œ ๋””์ž์ด๋„ˆ๋‹˜์ด๋ž‘ ์–˜๊ธฐ๋ฅผ ํ•ด์•ผํ•  ๊ฒƒ ๊ฐ™์•„์š”

@jinukeu
Copy link
Member Author

jinukeu commented Jan 24, 2024

๋„ค ๋””์ž์ด๋„ˆ๋ถ„์ด๋ž‘ ์–˜๊ธฐํ•ด๋ณผ๊ฒŒ์š”~! ์˜๊ฒฌ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค~

@jinukeu
Copy link
Member Author

jinukeu commented Jan 24, 2024

image
ํœด ...

@jinukeu jinukeu merged commit 21fb7b0 into develop Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] ํˆฌํ‘œ ์ž‘์„ฑ
2 participants