-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mz 129 my statistics #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
애니메이션 어려운 작업인데 고생 많으셨습니다~!
@@ -0,0 +1,12 @@ | |||
package com.susu.core.model | |||
|
|||
data class MyStatistics( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요놈 Contract에서도 사용하는 것 같은데 @Stable
마크 붙여주세유~! (StatisticsElement 도 붙여주세요)
fun RecentSpentGraph( | ||
modifier: Modifier = Modifier, | ||
isActive: Boolean = true, | ||
spentData: List<StatisticsElement> = emptyList(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PersistentList 써주세요~
…to feature/MZ-129-my-statistics
Stable, Immutable 같은 개념들 계속 빼먹는데 항상 잘 짚어주셔서 감사합니다 👍 |
💡 Issue
✅ To Reviewers
StatisticsRepositoryImpl
의 일부 코드는 api 변경이 완료되면 삭제합니다.📸 스크린샷
default.mp4