Feature/mz 129 my statistics #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
approved these changes
Jan 25, 2024
| @@ -0,0 +1,12 @@ | |||
| package com.susu.core.model | |||
|
|
|||
| data class MyStatistics( | |||
There was a problem hiding this comment.
요놈 Contract에서도 사용하는 것 같은데 @Stable 마크 붙여주세유~! (StatisticsElement 도 붙여주세요)
| fun RecentSpentGraph( | ||
| modifier: Modifier = Modifier, | ||
| isActive: Boolean = true, | ||
| spentData: List<StatisticsElement> = emptyList(), |
…to feature/MZ-129-my-statistics
|
Stable, Immutable 같은 개념들 계속 빼먹는데 항상 잘 짚어주셔서 감사합니다 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
✅ To Reviewers
StatisticsRepositoryImpl의 일부 코드는 api 변경이 완료되면 삭제합니다.📸 스크린샷
default.mp4