Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Base] #14 디자인 시스템 수정 및 추가구현 #17

Merged
merged 4 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,14 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import pokitmons.pokit.core.ui.R
import pokitmons.pokit.core.ui.components.block.pokitlist.attributes.PokitListState
import pokitmons.pokit.core.ui.theme.PokitTheme

Expand All @@ -27,10 +22,9 @@ fun <T> PokitList(
item: T,
title: String,
sub: String,
onClickKebab: (T) -> Unit,
onClickItem: (T) -> Unit,
modifier: Modifier = Modifier,
state: PokitListState = PokitListState.DISABLE,
state: PokitListState = PokitListState.DEFAULT,
) {
val titleTextColor = getTitleTextColor(state = state)
val subTextColor = getSubTextColor(state = state)
Expand Down Expand Up @@ -62,20 +56,6 @@ fun <T> PokitList(
style = PokitTheme.typography.detail1.copy(color = subTextColor)
)
}

IconButton(
onClick = { onClickKebab(item) },
modifier = Modifier
.padding(0.dp)
.align(Alignment.Top),
enabled = state != PokitListState.DISABLE
) {
Icon(
painter = painterResource(id = R.drawable.icon_24_kebab),
contentDescription = null,
modifier = Modifier.size(24.dp)
)
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ fun PokitListPreview() {
item = "STRING",
title = "카테고리입니당",
sub = "15개 항목",
onClickKebab = {},
onClickItem = {}
)

Expand All @@ -32,7 +31,6 @@ fun PokitListPreview() {
item = "STRING",
title = "카테고리입니당",
sub = "15개 항목",
onClickKebab = {},
onClickItem = {}
)

Expand All @@ -41,7 +39,6 @@ fun PokitListPreview() {
item = "STRING",
title = "카테고리입니당",
sub = "15개 항목",
onClickKebab = {},
onClickItem = {}
)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package pokitmons.pokit.core.ui.components.template.modifybottomsheet

import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import pokitmons.pokit.core.ui.R
import pokitmons.pokit.core.ui.components.template.bottomsheet.PokitBottomSheet
import pokitmons.pokit.core.ui.components.template.modifybottomsheet.subcomponents.ModifyBottomSheetItem

@Composable
fun ModifyBottomSheet(
onHideBottomSheet: () -> Unit,
onClickShare: (() -> Unit)? = null,
onClickModify: (() -> Unit)? = null,
onClickRemove: (() -> Unit)? = null,
) {
PokitBottomSheet(onHideBottomSheet = onHideBottomSheet) {
Column(
modifier = Modifier.fillMaxWidth()
) {
onClickShare?.let { onClickShare ->
ModifyBottomSheetItem(
onClick = {},
title = stringResource(id = R.string.share),
painter = painterResource(id = R.drawable.icon_24_share)
)
}

onClickModify?.let { onClickModify ->
ModifyBottomSheetItem(
onClick = onClickModify,
title = stringResource(id = R.string.modify),
painter = painterResource(id = R.drawable.icon_24_edit)
)
}

onClickRemove?.let { onClickRemove ->
ModifyBottomSheetItem(
onClick = onClickRemove,
title = stringResource(id = R.string.remove),
painter = painterResource(id = R.drawable.icon_24_trash)
)
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package pokitmons.pokit.core.ui.components.template.modifybottomsheet

import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.material3.Button
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import pokitmons.pokit.core.ui.theme.PokitTheme

@Preview(showBackground = true)
@Composable
private fun ModifyBottomSheetPreview() {
var showBottomSheet by remember { mutableStateOf(false) }

PokitTheme {
Surface(modifier = Modifier.fillMaxSize()) {
Button(onClick = { showBottomSheet = true }) {
Text(text = "Click!")
}

if (showBottomSheet) {
ModifyBottomSheet(
onHideBottomSheet = {},
onClickRemove = {},
onClickModify = {},
onClickShare = {}
)
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package pokitmons.pokit.core.ui.components.template.modifybottomsheet.subcomponents

import androidx.compose.foundation.Image
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.painter.Painter
import androidx.compose.ui.unit.dp
import pokitmons.pokit.core.ui.theme.PokitTheme

@Composable
internal fun ModifyBottomSheetItem(
onClick: () -> Unit,
title: String,
painter: Painter,
) {
Row(
modifier = Modifier
.fillMaxWidth()
.clickable {
onClick()
}
.padding(horizontal = 24.dp, vertical = 20.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.SpaceBetween
) {
Text(
text = title,
style = PokitTheme.typography.body1Medium.copy(color = PokitTheme.colors.textSecondary)
)

Image(
modifier = Modifier.size(24.dp),
painter = painter,
contentDescription = null
)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package pokitmons.pokit.core.ui.components.template.removeItemBottomSheet

import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.material3.Button
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import pokitmons.pokit.core.ui.components.template.removeItemBottomSheet.attributes.RemoveItemType
import pokitmons.pokit.core.ui.theme.PokitTheme

@Preview(showBackground = true)
@Composable
private fun RemoveItemBottomSheetPreview() {
var showBottomSheet by remember { mutableStateOf(false) }

PokitTheme {
Surface(modifier = Modifier.fillMaxSize()) {
Button(onClick = { showBottomSheet = true }) {
Text(text = "Click!")
}

if (showBottomSheet) {
RemoveItemBottomSheet(
removeItemType = RemoveItemType.LINK,
onHideBottomSheet = remember {
{ showBottomSheet = false }
},
onClickCancel = {},
onClickRemove = {}
)
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
package pokitmons.pokit.core.ui.components.template.removeItemBottomSheet

import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import pokitmons.pokit.core.ui.R
import pokitmons.pokit.core.ui.components.atom.button.PokitButton
import pokitmons.pokit.core.ui.components.atom.button.attributes.PokitButtonShape
import pokitmons.pokit.core.ui.components.atom.button.attributes.PokitButtonSize
import pokitmons.pokit.core.ui.components.atom.button.attributes.PokitButtonStyle
import pokitmons.pokit.core.ui.components.atom.button.attributes.PokitButtonType
import pokitmons.pokit.core.ui.components.template.bottomsheet.PokitBottomSheet
import pokitmons.pokit.core.ui.components.template.removeItemBottomSheet.attributes.RemoveItemType
import pokitmons.pokit.core.ui.theme.PokitTheme

@Composable
fun RemoveItemBottomSheet(
removeItemType: RemoveItemType,
onHideBottomSheet: () -> Unit,
onClickCancel: () -> Unit,
onClickRemove: () -> Unit,
) {
PokitBottomSheet(onHideBottomSheet = onHideBottomSheet) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(top = 36.dp, start = 20.dp, end = 20.dp, bottom = 20.dp),
horizontalAlignment = Alignment.CenterHorizontally
) {
Text(
text = stringResource(id = removeItemType.titleStringResourceId),
style = PokitTheme.typography.title2.copy(color = PokitTheme.colors.textPrimary)
)

Spacer(modifier = Modifier.height(8.dp))

Text(
text = stringResource(id = removeItemType.subStringResourceId),
style = PokitTheme.typography.body2Medium.copy(color = PokitTheme.colors.textSecondary),
textAlign = TextAlign.Center
)
}

Row(
modifier = Modifier
.fillMaxWidth()
.padding(top = 16.dp, start = 20.dp, end = 20.dp, bottom = 28.dp),
horizontalArrangement = Arrangement.spacedBy(8.dp)
) {
PokitButton(
text = stringResource(id = R.string.cancellation),
icon = null,
onClick = onClickCancel,
shape = PokitButtonShape.RECTANGLE,
type = PokitButtonType.SECONDARY,
size = PokitButtonSize.LARGE,
style = PokitButtonStyle.STROKE,
modifier = Modifier.weight(1f)
)

PokitButton(
text = stringResource(id = R.string.removal),
icon = null,
onClick = onClickRemove,
shape = PokitButtonShape.RECTANGLE,
type = PokitButtonType.PRIMARY,
size = PokitButtonSize.LARGE,
style = PokitButtonStyle.FILLED,
modifier = Modifier.weight(1f)
)
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package pokitmons.pokit.core.ui.components.template.removeItemBottomSheet.attributes

import pokitmons.pokit.core.ui.R

enum class RemoveItemType(val titleStringResourceId: Int, val subStringResourceId: Int) {
POKIT(
titleStringResourceId = R.string.title_remove_pokit,
subStringResourceId = R.string.sub_remove_link
),
LINK(
titleStringResourceId = R.string.title_remove_link,
subStringResourceId = R.string.sub_remove_link
),
}
12 changes: 12 additions & 0 deletions core/ui/src/main/res/values/string.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,16 @@
<resources>
<string name="not_read">안읽음</string>
<string name="pokit_count_format">링크 %d개</string>

<string name="title_remove_pokit">포킷을 정말 삭제하시겠습니까?</string>
<string name="sub_remove_pokit">함께 저장한 모든 링크가 삭제되며,\n복구하실 수 없습니다.</string>
<string name="title_remove_link">링크를 정말 삭제하시겠습니까?</string>
<string name="sub_remove_link">함께 저장한 모든 정보가 삭제되며,\n복구하실 수 없습니다.</string>

<string name="cancellation">취소</string>
<string name="removal">삭제</string>

<string name="share">공유하기</string>
<string name="modify">수정하기</string>
<string name="remove">삭제하기</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ fun AddLinkScreen(
item = it,
title = it.title,
sub = stringResource(id = R.string.count_format, it.count),
onClickKebab = onClickSelectPokitItem,
onClickItem = onClickSelectPokitItem,
state = PokitListState.ACTIVE
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ fun AddPokitScreen(
item = item,
title = item.title,
sub = stringResource(id = coreString.pokit_count_format, item.count),
onClickKebab = {},
onClickItem = {},
state = PokitListState.DEFAULT
)
Expand Down
Loading