feat: 배치 예외 처리 AOP 구현, 예외 발생 시 Slack에 알림 전송 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sooyoungh
commented
Jul 15, 2023
Comment on lines
+30
to
+33
| @AfterThrowing(value = "allBatchService()", throwing = "exception") | ||
| public void catchBatchException(JoinPoint joinPoint, PyonsnalcolorBatchException exception) { | ||
| log.error("[{}] 배치 실행 중 {}에서 예외가 발생하였습니다.", exception.getClass().getSimpleName(), | ||
| joinPoint.getTarget().getClass().getSimpleName()); |
There was a problem hiding this comment.
이후에 @Around으로 바꿔서
크롤링 후에 새 상품 slack 알림, 실패 시 slack 알림 등 일괄 처리하기
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 사항
참고 사항
배치에서의 IllegalException은 따로 알림등의 처리를 해주기 위해서)
슬랙에 예외 상황 알림 전송 테스트 참고
log 출력