wrappers: a series of engine wrappers has been initialized for support functionality in all builds #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmileyAG
added
high-priority
SmileyAG
changed the title
YaLTeR
reviewed
Jul 27, 2024
|
|
||
| namespace Engine | ||
| { | ||
| }; |
There was a problem hiding this comment.
Namespaces in .cpp have trailing ; but in .hpp they don't?
There was a problem hiding this comment.
In general, semicolon at the end for the named namespace is not required by standards. But if we look at the code design from other files of this project, it is clear that someone will put them both in the header and in .cpp, someone decides to put them only in the header, somewhere they are simply not there. So it's all a matter of taste.
But if we still want to adhere to some consistency in the code design, then I think it's easier to remove them altogether. What do you think about this?
There was a problem hiding this comment.
Yeah, let's do that if they are not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrappers were also divided into separate components for easier navigation and management, since I don’t like it when everything is in one basket.
Content for them will appear with the following pull requests, this request is intended to resolve the issue of what they should look like.