Add bxt_lightstyle #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have had some weirdly random crashes at map startup while testing on Windows but I am not sure if this is the cause as I don't see any backtrace. Might as well attribute it to WINE. After 5 minutes of restarting the game, it just stopped. Might be nothing but it might be something in the future if we want to see where to point our fingers at. |
YaLTeR
requested changes
Feb 14, 2024
|
I did a more testing and I see that a named light won't be overridden by this. But general lighting would be affected. |
YaLTeR
reviewed
Feb 15, 2024
src/modules/lightstyle.rs
Outdated
Comment on lines
134
to
138
| let cl_lightstyle = &mut unsafe { *engine::cl_lightstyle.get(marker) }; | ||
|
|
||
| // More often a map's default lightstyle will be empty. | ||
| *ORIGINAL_LIGHTSTYLE.borrow_mut(marker) = cl_lightstyle[0].map.to_vec(); | ||
| apply_from_cvars(marker); |
There was a problem hiding this comment.
This is holding a &mut reference on lightstyle while it is modified in apply_from_cvars, which is UB. Limit the scope of the &mut.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka night vision
No need for mat_fullbright 1 and -75% fps if use this one instead. No need for tweaking gamma and brightness either. Most importantly, no need to restart the map.