apply fix to #894 as suggested by @sodiboo #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested by @sodiboo in YaLTeR#894 (comment) and was copied from sodiboo/niri-flake@350e6b68c70f5002a75e10521f5e66ace4b5eed1i Signed-off-by: Maximilian Huber <[email protected]>
|
I would also suggest to fail on nix tests with: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 93968b0..4f88664 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -182,14 +182,11 @@ jobs:
- name: Check flake inputs
uses: DeterminateSystems/flake-checker-action@v4
- continue-on-error: true
- name: Install Nix
uses: DeterminateSystems/nix-installer-action@v3
- continue-on-error: true
- run: nix flake check
- continue-on-error: true
publish-wiki:
if: github.event_name == 'push' && github.ref == 'refs/heads/main' |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested by @sodiboo in #894 (comment) and was copied from sodiboo/niri-flake@350e6b68c70f5002a75e10521f5e66ace4b5eed1i
This closes #894