#52 #55
Open
#52 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakov-Varnaev
requested changes
Mar 26, 2024
There was a problem hiding this comment.
- Fix naming as it is a bit off the topic of the feature
- Don't use
batteriesif they don't solve your problem. It seems like neither filter forms nor Dango filters help us to make querying sufficient - We need more test cases.
Tests I'd like to see:
- One point has multiple stocks and usages
- Two points have multiple stocks and usages in the same period
- Two points have multiple stocks and usages in the non-intersecting periods
- One point has stocks and usages and the other is the empty one.
Yakov-Varnaev
requested changes
Apr 5, 2024
tests/apps/companies/services/test_materials_statistic_validator.py
Outdated
Show resolved
Hide resolved
src/companies/api/viewsets/point.py
Outdated
| @@ -33,3 +40,17 @@ def add_employees(self, *args: Any, **kwargs: Any) -> Response: | |||
| serializer = EmployeeSerializer(data=self.request.data, context=self.get_serializer_context(*args, **kwargs)) | |||
| employee = EmployeeCreator(serializer)() | |||
| return Response(EmployeeSerializer(employee).data) | |||
|
|
|||
|
|
|||
| class MaterialsStatisticViewSet(ModelViewSet): | |||
There was a problem hiding this comment.
Are you saying that we won't have a retrieve logic at the front? Do I need to remove the retrieve method?
There was a problem hiding this comment.
I can use mixins.ListModelMixin and GenericViewSet.
| ), | ||
| data=material_date_query_params, | ||
| ) | ||
| for movement in [response["stocks"], response["usage"]]: |
There was a problem hiding this comment.
This is the movement of materials. That is, delivery to the point and use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.