Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yc.o sync #1591

Merged
merged 60 commits into from
Nov 8, 2024
Merged

yc.o sync #1591

merged 60 commits into from
Nov 8, 2024

Conversation

xorrkaz
Copy link
Contributor

@xorrkaz xorrkaz commented Oct 9, 2024

No description provided.

Miroslav Kovac and others added 30 commits August 18, 2024 18:05
einarnn
einarnn previously approved these changes Oct 22, 2024
@einarnn einarnn dismissed their stale review October 22, 2024 10:15

Didn't look at CI check failures.

@einarnn
Copy link
Member

einarnn commented Oct 22, 2024

@xorrkaz, there are a bunch of errors in the IETF content. Will you be looking at those?

@xorrkaz
Copy link
Contributor Author

xorrkaz commented Oct 22, 2024

I am watching. The problem is missing IANA modules. The IANA sync job is running, and I saw one leak out recently. I don't know why the rest are not. If they don't get pushed before 121, I'll spend some time there sorting it.

@xorrkaz
Copy link
Contributor Author

xorrkaz commented Oct 22, 2024

Ah, actually, I lied @einarnn. The modules do exist in the repo. Your search path is wrong. The IANA modules are spread between extracted and standard, but the search path in the failing job is /home/runner/work/yang/yang/standard/ieee/published/. Can you expand the path to cover all module locations?

@xorrkaz
Copy link
Contributor Author

xorrkaz commented Oct 22, 2024

I think the ietf check.sh script needs something IANA-focused akin to:

ieee_dir_flag="--path $cwd/$ieee_dir/published/"

Such as:

iana_dir="standard/iana"
iana_dir_flag="--path $cwd/$iana_dir/"
pyang_flags="--verbose $ieee_dir_flag $iana_dir_flag"

That won't fix all of the issues right now. But it seems like IANA is lagging a bit in tracking drafts turning into RFCs. I think they will eventually all work.

@einarnn
Copy link
Member

einarnn commented Oct 27, 2024

@xorrkaz, it would be better if whoever is committing changes that broke the check scripts als fixed the check scripts as part of their commit. Was this broken by this commit or by a different one?

@xorrkaz
Copy link
Contributor Author

xorrkaz commented Oct 28, 2024

It's not a question of a commit. The IANA modules are now automatically updated in their own directory. My other PR fixed looking for those. However, in the case of these IANA SSH modules, their repo still refers to the drafts and not the RFCs. Therefore, they aren't being added to the standard/iana directory. I'll try and figure out when/how those get updated with IANA while I'm at the 121 meeting.

@xorrkaz
Copy link
Contributor Author

xorrkaz commented Nov 6, 2024

I spoke with Sabrina from IANA, and she said the SSH modules are pending a review from Kent Watsen. Once that clears, they should be fully published, and the pyang parsing should succeed.

@einarnn einarnn merged commit 946fa18 into YangModels:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants