Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: various updates #369

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Docs: various updates #369

merged 2 commits into from
Dec 16, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Dec 16, 2023

Context

  • Code QA/consistency

Summary

This PR can be summarized in the following changelog entry:

  • Code QA/consistency

Relevant technical choices:

  • Docs: improve type specificity
  • Docs: add missing return type void annotations

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A No functional changes.

@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Dec 16, 2023
@jrfnl jrfnl added this to the 3.2 milestone Dec 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7229463239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.143%
Totals Coverage Status
Change from base Build 7229402228: 0.0%
Covered Lines: 172
Relevant Lines: 301
💛 - Coveralls

@jrfnl jrfnl merged commit 3ccdfbb into develop Dec 16, 2023
16 checks passed
@jrfnl jrfnl deleted the JRF/docs-various-updates branch December 16, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @coveralls