Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YoastCS rules: flag unused/undefined variables #361

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 14, 2023

Composer: add VariableAnalysis package requirement

YoastCS rules: flag unused/undefined variables

Related to #303

Impact on Yoast packages (individual results still need review):

Plugin/Tool Errors/Warnings
PHPUnit Polyfills --
WP Test Utils --
YoastCS 5
WHIP 1
Yoast Test Helper 5
Duplicate Post --
Yst ACF --
Yst WooCommerce --
Yst News 2
Yst Local 99
Yst Video 38
Yst Premium 33
Yst Free 108

Related to 303

Impact on Yoast packages (individual results still need review):

| Plugin/Tool       | Errors/Warnings |
|-------------------|-----------------|
| PHPUnit Polyfills | --
| WP Test Utils     | --
| YoastCS           | 5
| WHIP              | 1
| Yoast Test Helper | 5
| Duplicate Post    | --
| Yst ACF           | --
| Yst WooCommerce   | --
| Yst News          | 2
| Yst Local         | 99
| Yst Video         | 38
| Yst Premium       | 33
| Yst Free          | 108
@coveralls
Copy link

Coverage Status

coverage: 99.411%. remained the same
when pulling 106b5e3 on JRF/yoastcs-variable-analysis
into 340b3a2 on develop.

@jrfnl jrfnl merged commit 12e1d05 into develop Dec 14, 2023
28 checks passed
@jrfnl jrfnl deleted the JRF/yoastcs-variable-analysis branch December 14, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants