YoastCS: more namespace/import use rules #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. in namespaced files and don't allow the use of fully qualified inline names for non-namespaced files. Note: this sniff does not/cannot flag missing import `use` statements for the use of _unqualified_ classes inline or in docblocks as it cannot know whether that is a class within the same namespace (no `use` statement needed) or from another namespace. This is a known limitation of sniffs no matter what. Related to 303 Fixes 201 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | 1 | Yoast Test Helper | 1 | Duplicate Post | 1 | Yst ACF | -- | Yst WooCommerce | 53 | Yst News | 24 | Yst Local | 59 | Yst Video | 37 | Yst Premium | 128 | Yst Free | 250 Note: this rule was previously already largely "silently" enforced via clean-up sweeps.
Related to 303 Fixes 213 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | 1 | Yst Premium | 3 | Yst Free | 15 Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | 4 (due to backport from the 2.x branch to 1.x) | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | 2 | Yst Free | 5 Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | 1 | Yst Premium | -- | Yst Free | 2 Note: this rule was previously already "silently" enforced via clean-up sweeps.
…he namespace Related to 214, 215, 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | 1 | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | 1 | Yst News | 2 | Yst Local | -- | Yst Video | -- | Yst Premium | 18 | Yst Free | 46 Note: this rule was previously already "silently" enforced via clean-up sweeps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YoastCS rules: enforce import use statements for all used classes
.. in namespaced files and don't allow the use of fully qualified inline names for non-namespaced files.
Note: this sniff does not/cannot flag missing import
usestatements for the use of unqualified classes inline or in docblocks as it cannot know whether that is a class within the same namespace (nousestatement needed) or from another namespace.This is a known limitation of sniffs no matter what.
Related to #303
Fixes #201
Impact on Yoast packages:
Note: this rule was previously already largely "silently" enforced via clean-up sweeps.
YoastCS rules: enforce alphabetically ordered import use statements
Related to #303
Fixes #213
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow unused import use statements
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow import use statements for the same namespace
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow use function/const in favour of importing the namespace
Related to #214, #215, #303
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: enforce fully qualified global functions and constants
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.