Feat:[snsproject] navigation-compose, hilt-navigation-compose 의존성 추가 … #24
Conversation
…및 화면 이동 구현 navigation compose를 이용하여 NavHost를 이용하여 화면 이동 구현 및 LoginViewModel 간단 구현 issue #6
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
presentation/src/main/java/com/example/presentation/login/LoginScreen.kt|106 col 21| Argument should be on a separate line (unless all arguments can fit a single line)
presentation/src/main/java/com/example/presentation/login/LoginScreen.kt|106 col 32| A multiline expression should start on a new line
presentation/src/main/java/com/example/presentation/login/LoginScreen.kt|109 col 68| Missing newline before ")"
presentation/src/main/java/com/example/presentation/login/LoginScreen.kt|109 col 69| Missing newline before ")"
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|11 col 21| Expected newline before annotation
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|11 col 29| Expected newline after last annotation
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|12 col 43| Missing trailing comma before ")"
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|14 col 1| Class body should not start with blank line
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|14 col 1| Trailing space(s)
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|22 col 1| Trailing space(s)
presentation/src/main/java/com/example/presentation/login/LoginViewModel.kt|22 col 5| Unexpected blank line(s) before "}"
presentation/src/main/java/com/example/presentation/login/WelcomeScreen.kt|21 col 5| No whitespace expected between opening parenthesis and first parameter name
presentation/src/main/java/com/example/presentation/login/WelcomeScreen.kt|21 col 42| No whitespace expected between last parameter and closing parenthesis
presentation/src/main/java/com/example/presentation/login/WelcomeScreen.kt|21 col 42| Missing trailing comma before ")"
app/build.gradle.kts
Outdated
| @@ -75,6 +75,8 @@ dependencies { | |||
| implementation(libs.converter.gson) | |||
| implementation(libs.hilt.android) | |||
| ksp(libs.hilt.android.compiler) | |||
| implementation(libs.androidx.hilt.navigation.compose) | |||
| implementation (libs.androidx.navigation.compose) | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:paren-spacing reported by reviewdog 🐶
Unexpected spacing before "("
presentation/build.gradle.kts
Outdated
| @@ -65,5 +65,7 @@ dependencies { | |||
| debugImplementation(libs.androidx.compose.ui.ui.test.manifest) | |||
| implementation(libs.hilt.android) | |||
| ksp(libs.hilt.android.compiler) | |||
| implementation(libs.androidx.hilt.navigation.compose) | |||
| implementation (libs.androidx.navigation.compose) | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:paren-spacing reported by reviewdog 🐶
Unexpected spacing before "("
| navController.navigate(LoginRoute.LoginScreen.route) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| composable(route = LoginRoute.LoginScreen.route) { | ||
| LoginScreen() | ||
| } | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| composable(route = LoginRoute.SignUpScreen.route) { | ||
| SignUpScreen(id = "", username = "", password1 = "", password2 = "", {}, {}, {}, {}, {}) | ||
| } | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| Modifier | ||
| .padding(top = 24.dp) | ||
| .fillMaxWidth(), | ||
| Modifier |
There was a problem hiding this comment.
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
| .padding(top = 24.dp) | ||
| .fillMaxWidth(), | ||
| Modifier | ||
| .padding(top = 24.dp) |
There was a problem hiding this comment.
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
| .fillMaxWidth(), | ||
| Modifier | ||
| .padding(top = 24.dp) | ||
| .fillMaxWidth(), |
There was a problem hiding this comment.
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
| text = "로그인", | ||
| onClick = {}, | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| Spacer(modifier = Modifier.weight(1f)) | ||
| Row(modifier = Modifier.align(Alignment.CenterHorizontally).padding(bottom = 24.dp).clickable(onClick = onNavigationToSignUpScreen)) { | ||
| Row(modifier = Modifier |
There was a problem hiding this comment.
🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("
…및 화면 이동 구현
navigation compose를 이용하여 NavHost를 이용하여 화면 이동 구현 및 LoginViewModel 간단 구현 issue #6
PR 템플릿
close #6 힐트와 Navgiation을 이용하여 viewModel, navHost 구현