Login feature #25
Login feature #25
Conversation
…d, password 변경 기능 구현
로컬 서버로 로그인을 통해 token값 반환받기, Retrofit hilt 구현 및 토큰값 결과를 토스트로 확인하기
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
data/src/main/java/com/example/data/usecase/LoginUseCaseImpl.kt|12 col 81| A multiline expression should start on a new line
data/src/main/java/com/example/data/usecase/LoginUseCaseImpl.kt|12 col 81| Newline expected before expression body
domain/build.gradle.kts|20 col 1| Trailing space(s)
| @@ -14,6 +19,9 @@ android { | |||
|
|
|||
| testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" | |||
| consumerProguardFiles("consumer-rules.pro") | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| @@ -48,4 +59,12 @@ dependencies { | |||
| ksp(libs.hilt.android.compiler) | |||
|
|
|||
| implementation(project(":domain")) | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| @@ -48,4 +59,12 @@ dependencies { | |||
| ksp(libs.hilt.android.compiler) | |||
|
|
|||
| implementation(project(":domain")) | |||
|
|
|||
| //retrofit | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:comment-spacing reported by reviewdog 🐶
Missing space after //
| //retrofit | ||
| implementation(libs.retrofit) | ||
| implementation(libs.converter.gson) | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| implementation(libs.retrofit) | ||
| implementation(libs.converter.gson) | ||
|
|
||
| //okhttp |
There was a problem hiding this comment.
🚫 [ktlint] standard:comment-spacing reported by reviewdog 🐶
Missing space after //
| import okhttp3.RequestBody | ||
|
|
||
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
|
|
||
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { |
There was a problem hiding this comment.
🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Missing spacing before ":"
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { | ||
| override suspend fun invoke(id: String, password: String): Result<String> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { | ||
| override suspend fun invoke(id: String, password: String): Result<String> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { | ||
| override suspend fun invoke(id: String, password: String): Result<String> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { | ||
| override suspend fun invoke(id: String, password: String): Result<String> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
| class LoginUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ): LoginUseCase { | ||
| override suspend fun invoke(id: String, password: String): Result<String> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before expression body
| @@ -12,6 +17,9 @@ android { | |||
|
|
|||
| testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" | |||
| consumerProguardFiles("consumer-rules.pro") | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
PR 템플릿
close #8
Retroif2를 이용해 로컬 서버 네트워크 연결
hilt 구현 및 viewmodel orbit 라이브러리를 사용하여 State와 SideEffect 코드 구현
로그인 결과 token을 토스트 메세지로 출력(에러 발생시 같이 토스트 출력)