Settings #27
Settings #27
Conversation
탑바에는 앱 이름을, 컨텐트에는 각 루트에 맞는 화면을 구성, 하단 바에는 3개의 탭이 존재(게시글, 게시글 추가 탭, 설정 탭)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
domain/src/main/java/com/example/domain/usecase/main/setting/GetMyUserUseCase.kt|6 col 35| Unexpected spacing before ":"
| import com.example.data.retrofit.UserService | ||
| import com.google.gson.GsonBuilder | ||
| import dagger.Module | ||
| import dagger.Provides | ||
| import dagger.hilt.InstallIn | ||
| import dagger.hilt.components.SingletonComponent | ||
| import okhttp3.Interceptor |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import
| import okhttp3.OkHttpClient | ||
| import okhttp3.Request |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import
| @@ -33,4 +35,7 @@ abstract class UserModule { | |||
|
|
|||
| @Binds | |||
| abstract fun bindClearUseCase(clearTokenUseCaseImpl: ClearTokenUseCaseImpl) : ClearTokenUseCase | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| @@ -33,4 +35,7 @@ abstract class UserModule { | |||
|
|
|||
| @Binds | |||
| abstract fun bindClearUseCase(clearTokenUseCaseImpl: ClearTokenUseCaseImpl) : ClearTokenUseCase | |||
|
|
|||
| @Binds | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
| @@ -33,4 +35,7 @@ abstract class UserModule { | |||
|
|
|||
| @Binds | |||
| abstract fun bindClearUseCase(clearTokenUseCaseImpl: ClearTokenUseCaseImpl) : ClearTokenUseCase | |||
|
|
|||
| @Binds | |||
| abstract fun bindGetMyUserUseCase(getMyUserUseCaseImpl: GetMyUserUseCaseImpl) : GetMyUserUseCase | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:function-return-type-spacing reported by reviewdog 🐶
Unexpected whitespace
| class GetMyUserUseCaseImpl @Inject constructor( | ||
| private val userService: UserService | ||
| ) : GetMyUserUseCase { | ||
| override suspend fun invoke(): Result<User> = runCatching { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before expression body
| val id: Long, | ||
| val loginId: String, | ||
| val username: String, | ||
| val profileImageUrl: String? = null |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| @@ -1,5 +1,5 @@ | |||
| package com.example.domain.usecase.login | |||
|
|
|||
| interface ClearTokenUseCase { | |||
| suspend operator fun invoke() | |||
| suspend operator fun invoke() : Result<Unit> | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:function-return-type-spacing reported by reviewdog 🐶
Unexpected whitespace
| @@ -1,5 +1,5 @@ | |||
| package com.example.domain.usecase.login | |||
|
|
|||
| interface ClearTokenUseCase { | |||
| suspend operator fun invoke() | |||
| suspend operator fun invoke() : Result<Unit> | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"
| import com.example.domain.model.User | ||
|
|
||
| interface GetMyUserUseCase { | ||
| suspend operator fun invoke() : Result<User> |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-return-type-spacing reported by reviewdog 🐶
Unexpected whitespace
Yoon-Chan
added
Feat
PR 템플릿
close #10 로그아웃 기능 및 설정 화면 구성
아직 설정 화면 프로필 변경 기능은 구현 x