게시글 목록 기능 구현들 #32
게시글 목록 기능 구현들 #32
Conversation
프로필 헤더 부분, 이미지 부분, 컨텐츠 부분, 댓글 부분을 나누어서 UI 구현 아직 데이터를 직접 받아와서 구현처리 X
옵션 버튼 누를 시 다이얼로그 출력으로 삭제 버튼 출력 삭제 버튼 클릭시 게시글 삭제 및 갱신
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
data/src/main/java/com/example/data/usecase/main/board/BoardPagingSource.kt|30 col 35| Missing spacing around "=="
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|7 col 29| Expected newline before annotation
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|7 col 37| Expected newline after last annotation
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|8 col 43| Missing trailing comma before ")"
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|9 col 2| Missing spacing before ":"
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|10 col 1| Class body should not start with blank line
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|10 col 1| Trailing space(s)
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|11 col 64| A multiline expression should start on a new line
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|11 col 64| Newline expected before expression body
data/src/main/java/com/example/data/usecase/main/board/DeleteBoardUseCaseImpl.kt|11 col 75| Missing spacing before "{"
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|12 col 26| Expected newline before annotation
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|12 col 34| Expected newline after last annotation
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|13 col 58| Missing trailing comma before ")"
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|15 col 1| Class body should not start with blank line
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|15 col 1| Trailing space(s)
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|16 col 70| A multiline expression should start on a new line
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|16 col 70| Newline expected before expression body
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|19 col 22| A multiline expression should start on a new line
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|22 col 14| Missing trailing comma before ")"
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|25 col 1| Trailing space(s)
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|25 col 5| Unexpected blank line(s) before "}"
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|26 col 1| Needless blank line(s)
data/src/main/java/com/example/data/usecase/main/board/GetBoardUseCaseImpl.kt|26 col 1| Trailing space(s)
domain/build.gradle.kts|58 col 1| Trailing space(s)
domain/build.gradle.kts|59 col 5| Missing space after //
domain/build.gradle.kts|60 col 19| Unexpected spacing before "("
domain/build.gradle.kts|61 col 23| Unexpected spacing before "("
domain/build.gradle.kts|62 col 19| Unexpected spacing before "("
domain/src/main/java/com/example/domain/model/Board.kt|10 col 32| Missing trailing comma before ")"
domain/src/main/java/com/example/domain/usecase/main/board/DeleteBoardUseCase.kt|5 col 9| No whitespace expected between opening parenthesis and first parameter name
domain/src/main/java/com/example/domain/usecase/main/board/DeleteBoardUseCase.kt|5 col 22| No whitespace expected between last parameter and closing parenthesis
domain/src/main/java/com/example/domain/usecase/main/board/DeleteBoardUseCase.kt|5 col 22| Missing trailing comma before ")"
domain/src/main/java/com/example/domain/usecase/main/board/DeleteBoardUseCase.kt|6 col 6| Unexpected whitespace
domain/src/main/java/com/example/domain/usecase/main/board/DeleteBoardUseCase.kt|6 col 7| Unexpected spacing before ":"
domain/src/main/java/com/example/domain/usecase/main/board/GetBoardUseCase.kt|7 col 1| Needless blank line(s)
| @@ -77,4 +77,7 @@ dependencies { | |||
|
|
|||
| //lifecycle service | |||
| implementation(libs.androidx.lifecycle.service) | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| @@ -77,4 +77,7 @@ dependencies { | |||
|
|
|||
| //lifecycle service | |||
| implementation(libs.androidx.lifecycle.service) | |||
|
|
|||
| //paging3 | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:comment-spacing reported by reviewdog 🐶
Missing space after //
| @@ -77,4 +77,7 @@ dependencies { | |||
|
|
|||
| //lifecycle service | |||
| implementation(libs.androidx.lifecycle.service) | |||
|
|
|||
| //paging3 | |||
| implementation (libs.androidx.paging.runtime) | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:paren-spacing reported by reviewdog 🐶
Unexpected spacing before "("
| @Module | ||
| @InstallIn(ActivityRetainedComponent::class) | ||
| abstract class BoardModule { | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
| @Module | ||
| @InstallIn(ActivityRetainedComponent::class) | ||
| abstract class BoardModule { | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| class BoardPagingSource @Inject constructor( | ||
| private val boardService: BoardService | ||
| ) : PagingSource<Int, Board>() { | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| anchorPage?.prevKey?.plus(1) ?: anchorPage?.nextKey?.minus(1) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| } | ||
| } | ||
|
|
||
| override suspend fun load(params: LoadParams<Int>): LoadResult<Int, Board> { |
There was a problem hiding this comment.
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
| val page: Int = params.key ?: 1 | ||
| val loadSize = params.loadSize | ||
| val response = boardService.getBoard(page = page, size = loadSize) | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
| val response = boardService.getBoard(page = page, size = loadSize) | ||
|
|
||
| val size = response.data.size | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-trailing-spaces reported by reviewdog 🐶
Trailing space(s)
PR 템플릿
close #12
close #13
close #14
close #15
close #16
close #17